Skip to content

Fix the enclave for deployment#387

Merged
shenkeyao merged 4 commits intocelo-integration-rebase-16.2from
keyao/fix-tee-registration
Apr 2, 2026
Merged

Fix the enclave for deployment#387
shenkeyao merged 4 commits intocelo-integration-rebase-16.2from
keyao/fix-tee-registration

Conversation

@shenkeyao
Copy link
Copy Markdown
Member

@shenkeyao shenkeyao commented Mar 30, 2026

Closes https://app.asana.com/1/1208976916964769/project/1209976130071762/task/1213873022354661?focus=true.

This PR:

  • Fixes the TEE verifier registration.
  • Fixes the enclave hash setup.
  • Sets up the readiness.

How to test this PR:

  • Verify that the TEE deployment works with these changes.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the enclave registration logic to interact with the EspressoTEEVerifier contract instead of the EspressoNitroTEEVerifier directly. Key changes include renaming getNitroVerifier to getVerifier, updating the return types to use the base verifier bindings, and introducing constants for teeTypeNitro and serviceTypeBatchPoster to support the updated contract method signatures for registering and checking enclave hashes. I have no feedback to provide.

@shenkeyao shenkeyao changed the title Fix the TEE registration Fix the enclave for deployment Mar 30, 2026
@shenkeyao shenkeyao marked this pull request as ready for review March 31, 2026 02:18
Copy link
Copy Markdown
Member

@jjeangal jjeangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested this PR with the production code and it works out just fine. I would simply recommend removing ports 9000 and 9001 and using 8337 and 8338 as it would make things more straightforward.

@shenkeyao shenkeyao merged commit 4c769c9 into celo-integration-rebase-16.2 Apr 2, 2026
39 checks passed
@shenkeyao shenkeyao deleted the keyao/fix-tee-registration branch April 2, 2026 23:13
QuentinI pushed a commit that referenced this pull request Apr 9, 2026
* Fix registration

* Add readiness

* Fix enclave retries

* Simplify ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants