feat: Replace local streamer with espresso-streamers package#388
feat: Replace local streamer with espresso-streamers package#388Sneh1999 merged 4 commits intocelo-integration-rebase-16.2from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Espresso streamer implementation by migrating to an external dependency, github.com/EspressoSystems/espresso-streamers/op. This change involves the removal of local batch buffering and streaming logic in favor of the new library. Feedback from the review identifies critical issues in the go.mod file, where the Go version and several dependency versions appear to be non-existent or future-dated. Additionally, there is a recommendation to clean up the PollInterval configuration and CLI flags, as the parameter has been removed from the streamer's initialization.
philippecamacho
left a comment
philippecamacho
left a comment
There was a problem hiding this comment.
LGTM.
Note we need to update the reference to the streamer code before creating a release for the audit.
* feat: Replace local streamer with espresso-streamers package * fix: use go mod * feat: use buffered streamer from espresso streamers repo * fix: use v1.0.0 package of espresso-streamers
2 participants
Description
This PR replaces the OP streamer with
espresso-streamerspackage and makes sure all tests pass.Note
There are still some things which need to be migrated to
espresso-streamersincluding moving the buffered streamer out