Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken flamegraph interaction in puffin_egui and puffin_viewer #115

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

emilk
Copy link
Collaborator

@emilk emilk commented Dec 15, 2022

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This broke in the recent egui 0.20 update (which I should have tested before approving…)

Related Issues

Closes #114

@emilk
Copy link
Collaborator Author

emilk commented Dec 15, 2022

We should do a patch release of both puffin_egui and puffin_viewer as soon as this is merged

Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch! Will do a patch soon. Ty!

@mergify mergify bot merged commit 923ba77 into main Dec 15, 2022
@mergify mergify bot deleted the emilk/fix-egui-flamegraph branch December 15, 2022 09:30
cchalmers added a commit to cchalmers/waveview that referenced this pull request Dec 28, 2022
@emilk
Copy link
Collaborator Author

emilk commented Jan 16, 2023

I don't think that patch release was ever made

@emilk emilk mentioned this pull request Jan 20, 2023
3 tasks
mergify bot pushed a commit that referenced this pull request Jan 20, 2023
### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

Release puffin_viewer 0.13.1 with the fix in
#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't interact with the flamegraph since the egui 0.20 upgrade
2 participants