Skip to content

Commit

Permalink
Fix broken flamegraph interaction in puffin_egui and puffin_viewer (#115
Browse files Browse the repository at this point in the history
)

### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

This broke in the recent egui 0.20 update (which I should have tested
before approving…)

### Related Issues

Closes #114
  • Loading branch information
emilk authored Dec 15, 2022
1 parent f5a43d5 commit 923ba77
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
3 changes: 3 additions & 0 deletions puffin_egui/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ All notable changes to the egui crate will be documented in this file.

<!-- next-header -->
## [Unreleased] - ReleaseDate

- [PR#115](https://github.com/EmbarkStudios/puffin/pull/115) Fix broken flamegraph interaction

## [0.19.0] - 2022-12-13

- [PR#112](https://github.com/EmbarkStudios/puffin/pull/112) You can now compile and run `puffin_egui` on the web
Expand Down
2 changes: 1 addition & 1 deletion puffin_egui/src/flamegraph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ pub fn ui(ui: &mut egui::Ui, options: &mut Options, frames: &SelectedFrames) {
info.painter
.set(where_to_put_timeline, Shape::Vec(timeline));

ui.allocate_rect(used_rect, Sense::click_and_drag());
ui.allocate_rect(used_rect, Sense::hover());
});
});
}
Expand Down
5 changes: 4 additions & 1 deletion puffin_viewer/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ All notable changes to `puffin_viewer` will be documented in this file.

<!-- next-header -->
## [Unreleased] - ReleaseDate

- [PR#115](https://github.com/EmbarkStudios/puffin/pull/115) Fix broken flamegraph interaction

## [0.13.0] - 2022-12-13

- Upgrade to `puffin_egui` 0.19.1
- Upgrade to `eframe` 0.20
- **Breaking:** WASM32 `start()` function in crate root is now async.
- **Breaking:** WASM32 `start()` function in crate root is now async.

## [0.12.1] - 2022-10-17
- [PR#93](https://github.com/EmbarkStudios/puffin/pull/93) Update to `egui` 0.19.
Expand Down

0 comments on commit 923ba77

Please sign in to comment.