Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't interact with the flamegraph since the egui 0.20 upgrade #114

Closed
emilk opened this issue Dec 15, 2022 · 0 comments · Fixed by #115
Closed

Can't interact with the flamegraph since the egui 0.20 upgrade #114

emilk opened this issue Dec 15, 2022 · 0 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@emilk
Copy link
Collaborator

emilk commented Dec 15, 2022

Can click on anything in it, can't zoom, etc.

I think this is related to emilk/egui#2244

A quick test with:

--- a/puffin_egui/examples/eframe.rs
+++ b/puffin_egui/examples/eframe.rs
@@ -7,7 +7,13 @@ fn main() {
     eframe::run_native(
         "puffin egui eframe",
         native_options,
-        Box::new(|_cc| Box::new(ExampleApp::default())),
+        Box::new(|cc| {
+            let mut style = (*cc.egui_ctx.style()).clone();
+            style.debug.show_blocking_widget = true;
+            cc.egui_ctx.set_style(style);
+
+            Box::new(ExampleApp::default())
+        }),
     );
 }

Shows that there are two interactive regions overlapping each other. I'm investigating…

@emilk emilk added the bug Something isn't working label Dec 15, 2022
@mergify mergify bot closed this as completed in #115 Dec 15, 2022
mergify bot pushed a commit that referenced this issue Dec 15, 2022
)

### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

This broke in the recent egui 0.20 update (which I should have tested
before approving…)

### Related Issues

Closes #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant