Adding basic sanity checks - #4120
Merged
Merged
Conversation
…ol into sanity_checks_basic
Extension for the new monitoring recipe "sanity checks".
…ol into sanity_checks_basic
…or (#3980) Co-authored-by: Manuel Schlund <manuel.schlund@dlr.de> Co-authored-by: Kirsten Schulze <b309296@levante2.lvt.dkrz.de> Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
…ol into sanity_checks_basic
Co-authored-by: Giulia Castellani <b383308@levante4.lvt.dkrz.de> Co-authored-by: Manuel Schlund <manuel.schlund@dlr.de> Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
LisaBock
marked this pull request as draft
July 22, 2025 14:51
LisaBock
added
the
requires new ESMValCore release
LisaBock
marked this pull request as ready for review
July 23, 2025 06:01
axel-lauer
requested changes
Jul 25, 2025
Contributor
There was a problem hiding this comment.
Thanks @LisaBock, this looks great! I tested this and the two recipes work nicely. I have two little suggestions:
- I think I would remove the dataset TROPFLUX (variable hfls) as I believe the sign is wrong (#4123) and because TROPFLUX only covers the Tropics, which makes the values hard to compare to the global averages that we are targeting.
- Now that the new CMORizer for ESACCI-CLOUD is merged (#3756), we could update all references to this dataset to the newly CMORized version (OBS6 instead of OBS).
Member
Author
|
Thanks @axel-lauer for your review! I updated the recipe to the new |
schlunma
reviewed
Jul 29, 2025
schlunma
reviewed
Jul 29, 2025
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
axel-lauer
reviewed
Aug 1, 2025
axel-lauer
reviewed
Aug 1, 2025
axel-lauer
approved these changes
Aug 1, 2025
Contributor
There was a problem hiding this comment.
Thank you for all the work @LisaBock ! This works nicely now with @schlunma 's fix ESMValGroup/ESMValCore#2789 and my two suggestions for recipe_create_ranges_obs.yml to take advantage of the new preprocessor align_metadata.
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
Co-authored-by: Axel Lauer <axel.lauer@dlr.de>
Co-authored-by: Bettina Gier <gier@uni-bremen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding basic sanity checks for monitoring model simulations.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic