Update ESACCI Cloud CMORizer (daily and monthly data)

[diegokam]

Description

This PR extends the capabilities of this branch by allowing to download and format daily and monthly ESA CCI Cloud data.
The ESA CCI Cloud website is: ESA CCI Cloud
- Daily Data can be found here.
- Monthly Data can be found here

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated data reformatting script

• 🛠 Documentation is available
• 🛠 The dataset has been added to the CMOR check recipe
• 🛠 The dataset has been added to the shared data pools of DKRZ and Jasmin by the @ESMValGroup/OBS-maintainers team
• 🧪 Numbers and units of the data look physically meaningful

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[LisaBock]

@axel-lauer and @schlunma I hopefully addressed all your comments and tested it again. Works fine for me.

Could you have another check on it? Thanks.

[schlunma]

Thanks for addressing my comments @LisaBock ! Looks great already, I only have a couple of minor comments left. I think this is almost ready 👍

[LisaBock]

Thanks for addressing my comments @LisaBock ! Looks great already, I only have a couple of minor comments left. I think this is almost ready 👍

Thanks again @schlunma ! I tried to address all new comments.

The only issue is the switch for downloading and cmorizing daily data. Is there another possibility for adding a switch for the download of daily data?The amount of daily data is so huge that I don't think we should have it as default.

[schlunma]

Thanks so much Lisa! Approving this from a technical point of view 🚀 I have not run the CMORizer again.

The only issue is the switch for downloading and cmorizing daily data. Is there another possibility for adding a switch for the download of daily data?The amount of daily data is so huge that I don't think we should have it as default.

As I already mentioned in the comment above, there's currently no simple way to achieve this, so I guess it's fine like this.

Thanks!!

[axel-lauer]

This looks very good and is almost ready to be merged. I suggest to also add the AM and PM datasets to recipe_check_obs.yml (please see suggested changes).
There seems to be, however, a problem with the monthly mean PM dataset. When using the dataset in a recipe (e.g. recipe_check_obs.yml), I get the following error message:

time: Frequency mon does not match input data

I suspect this might be caused by some month missing in the dataset and would need to be checked before merging the PR.

[LisaBock]

Thanks @axel-lauer for reviewing!
I now updated the recipe_check_obs.yml file to be able to test all datasets (AM, PM and AMPM). Thanks for spotting!

I also added a function to the formatter for filling in missing months. I had that already, but it got lost somehow in the process. for me, the tests worked fine.

[axel-lauer]

Looks all good now. Thank you @LisaBock