Skip to content

Conversation

@LisaBock
Copy link
Member

@LisaBock LisaBock commented Jul 28, 2025

Description

This PR fixes the ESACCI-Cloud cmorizer by removing the auxiliary coords "month_number" and "year".

  • Closes #issue_number
  • Link to documentation:

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

@LisaBock LisaBock requested a review from a team as a code owner July 28, 2025 14:54
@LisaBock LisaBock mentioned this pull request Jul 29, 2025
11 tasks
@schlunma
Copy link
Contributor

I wonder if it would make sense to remove these coordinates in the corresponding ESMValCore function.

It looks like for some (e.g., daily_statistics) this is already done, so it would probably make sense to do that for the others as well.

The only problem with this is that it may break existing diagnostics/CMORizers (wouldn't be to hard to check though, I guess). @ESMValGroup/technical-lead-development-team opinions?

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LisaBock, looks good! I recreated the monthly mean files and moved the new files to our OBS pool on Levante.

@axel-lauer axel-lauer merged commit 520148b into main Jul 30, 2025
8 checks passed
@axel-lauer axel-lauer deleted the fix_esacci_cloud_cmorizer branch July 30, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants