Update data finder imports

[bouweandela]

Description

Avoid issues due to importing private functions from ESMValCore. Related to ESMValGroup/ESMValCore#1835.

Closes #2973

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[bouweandela]

The tests are failing due to #2959

[remi-kazeroni]

Thanks @bouweandela! That looks good to me. Just one question: wouldn't it be needed to update environment_osx.yml as well?

[bouweandela]

Well spotted! Updated in 69e72c8

[bouweandela]

@remi-kazeroni Is there anything left to do on this pull request? The test failures appear unrelated, but I will try merging the main branch to see if it solves them.

[remi-kazeroni]

@remi-kazeroni Is there anything left to do on this pull request? The test failures appear unrelated, but I will try merging the main branch to see if it solves them.

No, the PR looks ready to me. I was hesitant to click the approval button because of the test failures. Let's see what we get with the latest merge of main.

[bouweandela]

@remi-kazeroni All green now!

[remi-kazeroni]

Thanks @bouweandela, the PR looks good to me! @valeriupredoi, I leave it to you to do a final check and merge 🍻

[valeriupredoi]

GA tests are failing from test recipe filler, @bouweandela you wanna have a look or should I (since that's my code); I can in a little while

[bouweandela]

It would be great if you could have a look at that in a new pull request. The recipe filler tool may not be that relevant anymore if we manage to include ESMValGroup/ESMValCore#1609 in the next release, but the deadline is getting near and we're not there yet, so it may be worth it to keep the recipe filler around for another release (or two to give people some time to transition).

[valeriupredoi]

Sounds good buds, am on the bus now, as soon as I get in work will remove the GA test call, approve and merge this, then open an issue and fix those tests in a PR 👍

[valeriupredoi]

nice @bouweandela - we are still importing private bits though ie _config 😉

[valeriupredoi]

issue for recipe_filler failed tests #2975 - I shalls fix 🎄

[valeriupredoi]

great work @bouweandela and @remi-kazeroni 🎄

[bouweandela]

@bouweandela - we are still importing private bits though ie _config 😉

I know, this pull request was about fixing the problems caused by importing from esmvalcore._data_finder. There is another one for importing from esmvalcore._config here #2736. I wish people stopped doing this and reviewers would start telling people not to do it.. this issue keeps coming back again and again.