Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 21, 2022

Description

Reduce the use of private functions from ESMValCore.

Partial solution to #1975.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@bouweandela bouweandela changed the title Read config-user.yml using experimental module Read config-user.yml using esmvalcore.config module Nov 4, 2022
@bouweandela bouweandela added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Nov 4, 2022
@bouweandela bouweandela mentioned this pull request Dec 16, 2022
8 tasks
@remi-kazeroni
Copy link
Contributor

Hi @bouweandela, would this be something to consider for the v2.8 release? Otherwise, we will continue to get the deprecation warning with the released version:

ESMValCore/esmvalcore/_config/__init__.py:13: ESMValCoreDeprecationWarning: The private module `esmvalcore._config` has been deprecated in ESMValCore version 2.8.0 and is scheduled for removal in version 2.9.0. Please use the public module `esmvalcore.config` instead.

@bouweandela bouweandela added this to the v2.8.0 milestone Feb 28, 2023
@bouweandela bouweandela removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Mar 13, 2023
@bouweandela bouweandela marked this pull request as ready for review March 13, 2023 09:31
@remi-kazeroni
Copy link
Contributor

@esmvalbot Please run examples/recipe_python.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 14, 2023

Since @remi-kazeroni asked, ESMValBot will run recipe examples/recipe_python.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 14, 2023

ESMValBot is happy to report recipe examples/recipe_python.yml ran OK, output has been generated here

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @bouweandela. Deprecation warnings no longer show up unless one uses deprecated options in their config_file. I tried a couple of recipes and CMORizers and all looks good.

Is it also planned to remove import esmvalcore._config from the tests in the Tool? This seems to be the case in tests/integration/test_recipes_loading.py and tests/system/data_simulator.py.

@bouweandela
Copy link
Member Author

Let's do that at a later point. The test tests/integration/test_recipes_loading.py is written to work with the old and the new version, but it has become a bit of a mess due to this. tests/system/data_simulator.py is more of an idea than something that is actually used.

@remi-kazeroni
Copy link
Contributor

@ESMValGroup/technical-lead-development-team could someone have a final look and merge that if all good?

@schlunma
Copy link
Contributor

Thanks both! Bouwe - would you mind opening an issue about updating these two files you mentioned? Thanks!

@schlunma schlunma merged commit 452f153 into main Mar 14, 2023
@schlunma schlunma deleted the update-cmorize-config-user branch March 14, 2023 15:00
@bouweandela
Copy link
Member Author

Cf. #3109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants