-
Notifications
You must be signed in to change notification settings - Fork 146
Read config-user.yml using esmvalcore.config module
#2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
esmvalcore.config module
|
Hi @bouweandela, would this be something to consider for the v2.8 release? Otherwise, we will continue to get the deprecation warning with the released version: ESMValCore/esmvalcore/_config/__init__.py:13: ESMValCoreDeprecationWarning: The private module `esmvalcore._config` has been deprecated in ESMValCore version 2.8.0 and is scheduled for removal in version 2.9.0. Please use the public module `esmvalcore.config` instead. |
|
@esmvalbot Please run examples/recipe_python.yml |
|
Since @remi-kazeroni asked, ESMValBot will run recipe examples/recipe_python.yml as soon as possible, output will be generated here |
|
ESMValBot is happy to report recipe examples/recipe_python.yml ran OK, output has been generated here |
remi-kazeroni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @bouweandela. Deprecation warnings no longer show up unless one uses deprecated options in their config_file. I tried a couple of recipes and CMORizers and all looks good.
Is it also planned to remove import esmvalcore._config from the tests in the Tool? This seems to be the case in tests/integration/test_recipes_loading.py and tests/system/data_simulator.py.
|
Let's do that at a later point. The test tests/integration/test_recipes_loading.py is written to work with the old and the new version, but it has become a bit of a mess due to this. |
|
@ESMValGroup/technical-lead-development-team could someone have a final look and merge that if all good? |
|
Thanks both! Bouwe - would you mind opening an issue about updating these two files you mentioned? Thanks! |
|
Cf. #3109 |
Description
Reduce the use of private functions from ESMValCore.
Partial solution to #1975.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: