[Release v2.8.0 or new esmvalcore release] Replace deprecated esmvalcore._data_finder module with esmvalcore.local -

[valeriupredoi]

Description - DO NOT MERGE YET - requires updated release of ESMValCore (either main or bugfix release)

Full development tests ie both esmvaltool and esmvalcore installed from source fail due to the deprecation of esmvalcore._data_finder module from ESMValCore dev 2.8dev via ESMValGroup/ESMValCore#1835

• Closes Tests fail in full development mode (esmvalcore and esmvaltool installed from source) due to _data_finder module deprecation #2973

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

[bouweandela]

This looks a bit related, so did you see #2958?

[valeriupredoi]

This looks a bit related, so did you see #2958?

looks like it should the same thing via different routes though, I'll have a closer look at that some time later, am still trying to figure out the shapely-related issue that's a bit more pressing now. BTW why don't you import the esmvalcore.local module straight into the diagnostic to set an example of how that module can be used?

[bouweandela]

Because _replace_tags is a private function that is not part of the public interface of esmvalcore.local. Importing it means we'll get in trouble again next time there are some changes in ESMValCore.

[valeriupredoi]

bwah! Very true @bouweandela - tell you what - am gonna close this coz tests are going stir mad in here anyway, so could you pls link #2973 to that PR of yours, add "needs ESMValCore release" label and turn on the full dev GA tests there so we know things go well? 🍺

[valeriupredoi]

actually add me as reviewer there, will do these myself 😃

[bouweandela]

Actually that branch works fine with both the current and the upcoming ESMValCore release, so there is no need for a new ESMValCore release.