updating changelog and CITATION in main to reflect files from 2.7.0 release #1756
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 202 202
Lines 10882 10882
=======================================
Hits 9921 9921
Misses 961 961 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Changes look good.
However, it feels weird to me to have a PR titled "updating changelog in main to reflect changelog from 2.7.0 release" with a 2.8 milestone 😬 Sorry I couldn't approve this PR yesterday, but as I mentioned I am currently travelling.
I also saw that some commits of the release branch (and thus of the release itself) are not included in main yet. Shouldn't the release (branch) always be a subset of the main branch? I really think we should merge the release branch into main.
|
not a worry, Manu! yeah, I will remove the Milestone, now that you pointed out that does sound a bit hacky after all 😁 Yes! Good call, I'll merge the release branch into main - actually here to reuse the PR |
valeriupredoi
changed the title
|
OK all is clean and placed in here, you wanna have another look @schlunma pls 🍺 |
|
Awesome, cheers 🍺 Let's merge #1757 before this one here, so that everything aligns nicely. |
|
@valeriupredoi You will also need update the changelog of the already released version v2.7 somehow: https://docs.esmvaltool.org/projects/ESMValCore/en/v2.7.0/changelog.html For future releases, I would recommend making sure everything is included in the release before actually making the release. |
|
No need to, guys, all that is in the release changelog, I took care of that
yesterday 🍺
|
sorry, commented on the wrong PR (was supposed to be to #1757 - was on the bus, Reading buses are not optimal places to work on GitHub 😁 ) - thanks for the reviews, will merge now 🍺 |
Description
This is a bit of a departure from our usual way of updating the changelog, but I had to add a couple items to the Changelog in the release branch - the update of the changelog from #1746 and @schlunma 's very useful #1755 - I could have waited for a final final approval and only then moving it to the release branch, but given it's just two itty bitty changelog changes I'd rather get it done with the Core stable release 😁
This will be the first documentation entry for v2.8.0 yay!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: