Fix calculation of precipitation flux in EMAC on-the-fly CMORizer #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 202 202
Lines 10882 10882
=======================================
Hits 9921 9921
Misses 961 961
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
OK @schlunma I will include this in the release today, but you owe me a 🍺 for the extra hassle to change the changelog 😁 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A colleague of us informed us about a slight error in the calculation of the precipitation rate in EMAC. It should be aprc + aprl, right now we use aprc + aprl + aprs. This PR fixes that.
@valeriupredoi it would be really nice if this PR made it into the new relaese, so our colleagues can use it with the Levante module (which always uses the latest version). Since it's just a very minor chance I hope that's not a problem. Cheers! 🍺
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: