-
Notifications
You must be signed in to change notification settings - Fork 44
added changelog for v2.7.0 #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| v2.7.0rc1 | ||
| --------- | ||
| Highlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Higlights have to be added manually below this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I shall, will put them either in rc2 or (if all goes heavenly) the stable w/o needing rc2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then what do you need this pull request for if you have pre-released this on GitHub already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bookkeeping, just bookkeeping, will change it to rc2/stable on it once it's merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this was ready to be released because docs appear to be failing, same with tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests fail bc of this #1747 and docs are hitting the Django problem (need to check) - still - this is not deterring us from getting ahead of things and testing the recipes with rc1 (we should run those only with Python 3.10 though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs actually build, see builds think the badge is picking up a former fail for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, darn badge is picked up from esmvaltool docs builds instead of core 🤦♂️
doc/changelog.rst
Outdated
| Backwards incompatible changes | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| TODO: add examples of how to deal with these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing, maybe remind people working with non-default config files to be aware of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh good point, will do for rc2 or stable (whichever comes next) 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we'll defo need an rc2, but the bits we'll put in it will be all docs stuff, so no problem once testing finished with rc1 👍
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 202 202
Lines 10882 10882
=======================================
Hits 9921 9921
Misses 961 961 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
hi @sloosvel this is now ready-ready for the 2.7.0 release, could you pls have a looksee when you get some spare time, and tell me what you think 🍺 |
sloosvel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
@sloosvel you're a star ⭐ Cheers very much for looking at it! I'll merge, cherry-pick in the release branch, then we'll have us a nice and toasty stable release 🍺 |
Updated changelog for v2.7.0rc1 release candidate