Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

Updated changelog for v2.7.0rc1 release candidate

@valeriupredoi valeriupredoi added the documentation Improvements or additions to documentation label Oct 5, 2022
@valeriupredoi valeriupredoi requested a review from sloosvel October 5, 2022 14:17
@valeriupredoi valeriupredoi added this to the v2.7.0 milestone Oct 5, 2022

v2.7.0rc1
---------
Highlights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Higlights have to be added manually below this section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I shall, will put them either in rc2 or (if all goes heavenly) the stable w/o needing rc2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then what do you need this pull request for if you have pre-released this on GitHub already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bookkeeping, just bookkeeping, will change it to rc2/stable on it once it's merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this was ready to be released because docs appear to be failing, same with tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail bc of this #1747 and docs are hitting the Django problem (need to check) - still - this is not deterring us from getting ahead of things and testing the recipes with rc1 (we should run those only with Python 3.10 though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs actually build, see builds think the badge is picking up a former fail for some reason

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, darn badge is picked up from esmvaltool docs builds instead of core 🤦‍♂️

Backwards incompatible changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

TODO: add examples of how to deal with these changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing, maybe remind people working with non-default config files to be aware of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh good point, will do for rc2 or stable (whichever comes next) 🍺

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we'll defo need an rc2, but the bits we'll put in it will be all docs stuff, so no problem once testing finished with rc1 👍

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1746 (f326476) into main (9dec201) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1746   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files         202      202           
  Lines       10882    10882           
=======================================
  Hits         9921     9921           
  Misses        961      961           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@valeriupredoi valeriupredoi changed the title added changelog for v2.7.0rc1 added changelog for v2.7.0 Oct 12, 2022
@valeriupredoi
Copy link
Contributor Author

hi @sloosvel this is now ready-ready for the 2.7.0 release, could you pls have a looksee when you get some spare time, and tell me what you think 🍺

Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valeriupredoi
Copy link
Contributor Author

@sloosvel you're a star ⭐ Cheers very much for looking at it! I'll merge, cherry-pick in the release branch, then we'll have us a nice and toasty stable release 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants