Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github ci compile check for ascent #2483

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Oct 25, 2021

Adds github ci check that complies WarpX with Ascent=ON, using an Ascent container.

From here we could run a small test, render, image and provide that image as an artifact.

@ax3l ax3l self-requested a review October 25, 2021 22:15
@ax3l ax3l self-assigned this Oct 25, 2021
@ax3l ax3l added the component: diagnostics all types of outputs label Oct 25, 2021
.github/workflows/ascent.yml Outdated Show resolved Hide resolved
.github/workflows/insitu.yml Outdated Show resolved Hide resolved
.github/workflows/insitu.yml Show resolved Hide resolved
.github/workflows/insitu.yml Outdated Show resolved Hide resolved
@cyrush
Copy link
Member Author

cyrush commented Nov 3, 2021

@ax3l i have the container build test for Ascent sorted out.

Do you suggest we also run a small test and render a pictured as part of the process, if so what test would you recommend?

@cyrush
Copy link
Member Author

cyrush commented Nov 3, 2021

  • Cyrus: Add newline to end of CI yaml file.

@ax3l
Copy link
Member

ax3l commented Nov 3, 2021

@cyrush awesome, thanks a lot!

We could use the 3D laser-wakefield (LWFA) test: https://github.com/ECP-WarpX/WarpX/blob/development/Examples/Physics_applications/laser_acceleration/inputs_3d and render out in a single scene:

  • iso-contour of Ey (laser pulse)
  • volume rendering of Ey (just to check it works)
  • particle species: "electrons" colored by pz?

@cyrush
Copy link
Member Author

cyrush commented Nov 3, 2021

@ax3l sounds like a plan, I will tackle that soon.

@cyrush
Copy link
Member Author

cyrush commented Nov 3, 2021

I have the tests running :-)

I put the input deck and ascent actions file in .github/workflows/resources, not sure if this is a good place so please let me know if I should move elsewhere.

The setup also provides artifacts (pngs and blueprint files), you can see an example here:
https://github.com/ECP-WarpX/WarpX/actions/runs/1419129561

@ax3l
Copy link
Member

ax3l commented Nov 8, 2021

Thanks a lot, that's fantastic!

I put the input deck and ascent actions file in .github/workflows/resources, not sure if this is a good place so please let me know if I should move elsewhere.

Nice, I added some house-keeping updates in Alpine-DAV#1

The setup also provides artifacts

Awesome! For the Ey volume rendering, can you please set the color bar to be

  • symmetric around zero and
  • transparent for zero

? :)

- make sure inputs file stays up-to-date
- locate alongside example
@ax3l
Copy link
Member

ax3l commented Nov 9, 2021

Ups, let's rename Examples/Physics_applications/laser_acceleration/inputs_3d_ascent_test_ascent_actions.yaml to Examples/Physics_applications/laser_acceleration/3d_ascent_actions.yaml or so :)

.github/workflows/insitu.yml Outdated Show resolved Hide resolved
.github/workflows/insitu.yml Outdated Show resolved Hide resolved
@cyrush
Copy link
Member Author

cyrush commented Nov 11, 2021

@ax3l I updated the color table for the volume rendering example, here is the output (from the actions artifact)

ey_volrend_140

Let me know if there are other tweaks we should make.

@ax3l
Copy link
Member

ax3l commented Nov 15, 2021

@cyrush thanks a lot, awesome! Can we rotate the volume rendering figure by 90 degrees in the horizontal axis please? :)
(Positive z values to the right, if possible :) )

@cyrush
Copy link
Member Author

cyrush commented Nov 19, 2021

ey_volrend_40
uz_pc_40
ey_contour_pc_40

@ax3l How do these look?

Note: For contour, the extents are different post contour - so that is why it looks different from the other two.

@ax3l
Copy link
Member

ax3l commented Nov 19, 2021

Awesome! 🤩

Thanks a lot! 🚀 ✨

@ax3l ax3l merged commit 279aadf into ECP-WarpX:development Nov 19, 2021
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 29, 2021
* add github ci compile check for ascent

* now with less whitespace

* add ascent to insitu workflow

* Update .github/workflows/insitu.yml

Co-authored-by: Axel Huebl <[email protected]>

* more style

* try to run as existing user

* new container

* use env script

* path fix

* add ascent test

* fix space

* move test resources

* get into style

* style

* Ascent CI: Cleanup (ECP-WarpX#1)

- make sure inputs file stays up-to-date
- locate alongside example

* Update .github/workflows/insitu.yml

Co-authored-by: Axel Huebl <[email protected]>

* Update .github/workflows/insitu.yml

Co-authored-by: Axel Huebl <[email protected]>

* rename test file

* fix for cp

* improve color table for vol rendering

* now with rotation

Co-authored-by: Axel Huebl <[email protected]>
@ax3l ax3l mentioned this pull request Dec 22, 2022
5 tasks
WeiqunZhang pushed a commit to AMReX-Codes/amrex that referenced this pull request Dec 22, 2022
## Summary

Add a CI entry to build Ascent in situ vis.

## Additional background

cc @cyrush

- ECP-WarpX/WarpX#2483
- ECP-WarpX/WarpX#2858
- #3077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants