Ascent CI: Cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Nov 8, 2021
ax3l
commented
- make sure inputs file stays up-to-date
- locate alongside example
- make sure inputs file stays up-to-date - locate alongside example
cyrush
merged commit 0c9e77a
into
Alpine-DAV:task/2021_10_add_ascent_github_actions_ci_check
cyrush
added a commit
that referenced
this pull request
Feb 16, 2022
* add github ci compile check for ascent * now with less whitespace * add ascent to insitu workflow * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * more style * try to run as existing user * new container * use env script * path fix * add ascent test * fix space * move test resources * get into style * style * Ascent CI: Cleanup (#1) - make sure inputs file stays up-to-date - locate alongside example * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * rename test file * fix for cp * improve color table for vol rendering * now with rotation Co-authored-by: Axel Huebl <[email protected]>
cyrush
pushed a commit
that referenced
this pull request
Jun 30, 2023
…CP-WarpX#3890) * break application of PEC to rho into separate loops over boxes * round #1: fix failing CI tests * also apply the fix to the `ApplyPECtoJfield` * round 2: fix failing CI tests * round 3: fix failing CI tests * refactor PEC handling for charge and current density * removed unused variable * round 4: fix failing CI tests * Fix `mirrorfac` calculation for `rho` * only apply rho and J PEC boundaries for Cartesian grid (for now) in `SyncCurrentAndRho()` * use the same kernel to apply PEC boundary to rho and J * perform J and rho PEC application for RZ but warn about incorrect results if r_max is PEC * do not apply PEC boundary for rho and J to r-max in RZ * set warning level to medium and increase abort_on_warning_threshold to high for failing CI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.