-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nci corrector in gather buffer bugfix #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
approved these changes
Oct 2, 2018
Great! Thanks for these changes! |
lucafedeli88
added a commit
that referenced
this pull request
Jun 6, 2019
Merge pull request #1 from ECP-WarpX/qed_playground
dwillcox
pushed a commit
to dwillcox/WarpX
that referenced
this pull request
Sep 5, 2019
hightower8083
referenced
this pull request
in hightower8083/WarpX
Dec 2, 2020
fixed active window for negative end_step
1 task
ax3l
added a commit
that referenced
this pull request
Nov 19, 2021
* add github ci compile check for ascent * now with less whitespace * add ascent to insitu workflow * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * more style * try to run as existing user * new container * use env script * path fix * add ascent test * fix space * move test resources * get into style * style * Ascent CI: Cleanup (#1) - make sure inputs file stays up-to-date - locate alongside example * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * rename test file * fix for cp * improve color table for vol rendering * now with rotation Co-authored-by: Axel Huebl <[email protected]>
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 29, 2021
* add github ci compile check for ascent * now with less whitespace * add ascent to insitu workflow * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * more style * try to run as existing user * new container * use env script * path fix * add ascent test * fix space * move test resources * get into style * style * Ascent CI: Cleanup (ECP-WarpX#1) - make sure inputs file stays up-to-date - locate alongside example * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * Update .github/workflows/insitu.yml Co-authored-by: Axel Huebl <[email protected]> * rename test file * fix for cp * improve color table for vol rendering * now with rotation Co-authored-by: Axel Huebl <[email protected]>
roelof-groenewald
added a commit
that referenced
this pull request
May 16, 2023
…3890) * break application of PEC to rho into separate loops over boxes * round #1: fix failing CI tests * also apply the fix to the `ApplyPECtoJfield` * round 2: fix failing CI tests * round 3: fix failing CI tests * refactor PEC handling for charge and current density * removed unused variable * round 4: fix failing CI tests * Fix `mirrorfac` calculation for `rho` * only apply rho and J PEC boundaries for Cartesian grid (for now) in `SyncCurrentAndRho()` * use the same kernel to apply PEC boundary to rho and J * perform J and rho PEC application for RZ but warn about incorrect results if r_max is PEC * do not apply PEC boundary for rho and J to r-max in RZ * set warning level to medium and increase abort_on_warning_threshold to high for failing CI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the nci corrector to the coarse level fields when using the field gather buffer.
Before this fix:
After this fix:
Script to reproduce: