feat: add support for dydynvc #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
March 19, 2024 20:51
…receiving a ServerDeactivateAll on the I/O channel
sequences into a separate connection_activation module. This allows us to reuse them when we receive a Server Deactivate All.
`single_connect_step_read` and `single_connect_step_write`. Also adds a `ConnectionActivationSequence::reset_clone` method to aid in reusing the sequence for Deactivate All PDU handling. Passes `ConnectionActivationSequence` to `x224::Processor` to hand back upon receiving a Deactivate All PDU.
…:Windows::RDS::DisplayControl DVC to work.
…to us from the server via the BlockType in the BlockHeader, so it needn't be rigidly tracked explicitly in DecodingContext. This makes the RFX pipeline more flexible, which in turn allows us to seamlessly use it when we get another sync sequence mid-stream due to having fielded a Server Deactivate PDU.
…ess_dyvc to DrdynvcClient::process
client codebase. This uses `encode_dvc_data` to encode the DVC data responses. Currently no dynamic channels are added so the code is untested (WIP).
in the form of `DisplayControlClient`
I attempted to transfer everything in ironrdp_pdu::dvc::display into it, but it required more refactoring that I'd expected to get it to play nicely with the no_std possibility. This also removes the requirement of keeping track of the channel_id in each `DynamicVirtualChannel`, and instead lets the `DynamicChannelSet` take care of returning that as needed.
`DvcPduEncode` trait simply inherits `PduEncode`. It is a marker trait to indicate that the implementor, when encoded, is ready to be wrapped in DataFirst and/or Data PDU(s). `MonitorLayoutPdu` is a copy of the pdu by the same name in the `ironrdp-pdu` crate. It is moved (well, copied for now) to the `ironrdp-dvc` crate and implements `DvcPduEncode`.
added previously. Also creates a `DrdynvcPdu` enum that implements `SvcPduEncode`, and begins migrating `DataFirstPdu` and `DataPdu` to the new `PduEncode` paradigm. In the process, also: - Moved `DynamicVirtualChannel` and `DynamicChannelSet` from `client.rs` to `lib.rs` since they can ultimately be used by both client and server.
…id of now superfluous DvcMessage<'a>
… This has been tested to work for screen resize. The refactored server side code has not been tested.
…bles testing in ironrdp-dvc by eliminating the test = false line in Cargo.toml
Coverage Report 🤖 ⚙️Past: New: Diff: -0.54% [this comment will be updated automatically] |
|
This is likely going to conflict badly with #348 |
|
Thanks for the PR, I'll review it today! |
|
I feel like the right merge order will be the following:
cc @CBenoit |
CBenoit
reviewed
Mar 25, 2024
CBenoit
reviewed
Mar 25, 2024
| use core::fmt; | ||
| use slab::Slab; | ||
|
|
||
| use ironrdp_pdu as pdu; |
There was a problem hiding this comment.
thought: We should avoid this use ironrdp_pdu as pdu. It’s a bit confusing. (In follow-up PR.)
added 4 commits
March 25, 2024 11:46
…e framed module. These should be able to be used in both ironrdp-async/src/connector.rs and ironrdp-acceptor/src/lib.rs (however the latter has not been manually tested as of this commit).
ibeckermayer
force-pushed
the
feat/dynamic-resize
branch
from
9c735ec
to
89b28ac
Compare
4 tasks
|
|
@ibeckermayer can you rebase on top of master? |
CBenoit
reviewed
Mar 29, 2024
CBenoit
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
LGTM! New comments can be addressed in a follow up PR.
Thank you for the PR @ibeckermayer
Thank you for helping with reviewing @pacmancoder
This was referenced Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the gigantic PR, but much of this necessitated being done in one gasp. A lot of the changes here are moving PDUs that were under
crates/ironrdp-pdu/src/rdp/vc/dvcand using the oldPduParsingparadigm intocrates/ironrdp-dvcand forming them to the newerPduEncode/PduDecodeparadigm.I also added some practical facilities for working with arbitrary dynamic channels, taking inspiration from the existing patterns we have for static virtual channels.
No dynamic channels are hooked up yet for any of the IronRDP clients, however these changes were all tested manually via the
isaiah/resizebranch in Teleport.Depends on #418