Resize #39819
Merged
Resize #39819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eenSpecs to the backend. Currently just gets logged in the WDS
This message is now used both after the connection is first established and after the connection executes a Deactivation-Reactivation Sequence. This fits snugly in to our existing message flow and ensures that the fast path processor is updated appropriately whenever a Deactivation-Reactivation Sequence is executed due to a resize event.
…). Screen resize works in this commit, though its still the case that if you do so before the channel is announced by the rdp server, it will end the session
…r until we're alerted by a new callback mechanism of the DisplayControlClient that the server has sent us its capabilities. This prevents an error where we send a resize before this event, which results either in an RDP error (if the channel is not opened) or a dropped event (if the server has not sent its capabilities yet).
github-actions
bot
added
desktop-access
rdp
rfd
added 4 commits
March 25, 2024 20:35
zmb3
approved these changes
Apr 25, 2024
probakowski
approved these changes
Apr 29, 2024
public-teleport-github-review-bot
bot
removed request for
klizhentas,
russjones,
r0mant,
fheinecke,
camscale and
tcsc
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Resize * ??? * ??? * Fixes to compile * Updates to latest IronRDP with dvc fix, cleans up some of the debug code * Hooks up resize listener on the client and sends changes as ClientScreenSpecs to the backend. Currently just gets logged in the WDS * Handles the new DeactivateAll ProcessorOutput * hooks up client_write_screen_resize * Renames tdp Connection Initialized to Connection Activated This message is now used both after the connection is first established and after the connection executes a Deactivation-Reactivation Sequence. This fits snugly in to our existing message flow and ensures that the fast path processor is updated appropriately whenever a Deactivation-Reactivation Sequence is executed due to a resize event. * Switch monitor orientation based on width/height * remove superfluous canvas size sync * Updates to the most up-to-date hash for IronRDP (not merged to master). Screen resize works in this commit, though its still the case that if you do so before the channel is announced by the rdp server, it will end the session * Updates to the most recent hash for IronRDP feat/dynamic-resize * Adds a mechanism to withhold sending resize requests to the RDP server until we're alerted by a new callback mechanism of the DisplayControlClient that the server has sent us its capabilities. This prevents an error where we send a resize before this event, which results either in an RDP error (if the channel is not opened) or a dropped event (if the server has not sent its capabilities yet). * Refactoring after update to the tip of Devolutions/IronRDP#424 * Adds windowOnResize to story * adds Determine Toolchain Versions and cache paths and Print versions steps to os-compatibility-test.yaml * fixes debug log formatting * Updates to local IronRDP and later IronRDP api * updates to IronRDP latest rev on Devolutions/IronRDP#430 * reverting mistaken changes * throttle -> debounce and naming changes * js renamings * updates to IronRDP master --------- Co-authored-by: Przemko Robakowski <[email protected]>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Resize * ??? * ??? * Fixes to compile * Updates to latest IronRDP with dvc fix, cleans up some of the debug code * Hooks up resize listener on the client and sends changes as ClientScreenSpecs to the backend. Currently just gets logged in the WDS * Handles the new DeactivateAll ProcessorOutput * hooks up client_write_screen_resize * Renames tdp Connection Initialized to Connection Activated This message is now used both after the connection is first established and after the connection executes a Deactivation-Reactivation Sequence. This fits snugly in to our existing message flow and ensures that the fast path processor is updated appropriately whenever a Deactivation-Reactivation Sequence is executed due to a resize event. * Switch monitor orientation based on width/height * remove superfluous canvas size sync * Updates to the most up-to-date hash for IronRDP (not merged to master). Screen resize works in this commit, though its still the case that if you do so before the channel is announced by the rdp server, it will end the session * Updates to the most recent hash for IronRDP feat/dynamic-resize * Adds a mechanism to withhold sending resize requests to the RDP server until we're alerted by a new callback mechanism of the DisplayControlClient that the server has sent us its capabilities. This prevents an error where we send a resize before this event, which results either in an RDP error (if the channel is not opened) or a dropped event (if the server has not sent its capabilities yet). * Refactoring after update to the tip of Devolutions/IronRDP#424 * Adds windowOnResize to story * adds Determine Toolchain Versions and cache paths and Print versions steps to os-compatibility-test.yaml * fixes debug log formatting * Updates to local IronRDP and later IronRDP api * updates to IronRDP latest rev on Devolutions/IronRDP#430 * reverting mistaken changes * throttle -> debounce and naming changes * js renamings * updates to IronRDP master --------- Co-authored-by: Przemko Robakowski <[email protected]>
ibeckermayer
pushed a commit
that referenced
this pull request
May 4, 2024
`screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
* Ignores resizes when a desktop has `screen_size` set `screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set. * hasSizeOverride and //nolint
ibeckermayer
pushed a commit
that referenced
this pull request
May 6, 2024
* Ignores resizes when a desktop has `screen_size` set `screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set. * hasSizeOverride and //nolint
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
* Ignores resizes when a desktop has `screen_size` set `screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set. * hasSizeOverride and //nolint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds resize capabilities to Teleport. This required several changes to IronRDP:
Server Deactivate All PDUDevolutions/IronRDP#418DisplayControlClientDevolutions/IronRDP#424TODO:
RUST_VERSIONand bumps IronRDP rev to latest, addingRUST_MIN_STACKto fix ARM builds #39895masteronce the PRs above are merged.RUST_VERSIONand bumps IronRDP rev to latest, addingRUST_MIN_STACKto fix ARM builds #39895changelog: Adds resize capability to windows desktop sessions.