Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ffi): screenshot example using C# bindings #437

Merged
merged 18 commits into from
Apr 9, 2024
Merged

feat(ffi): screenshot example using C# bindings #437

merged 18 commits into from
Apr 9, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Apr 8, 2024 •
edited
Loading

  1. upgraded the connect example to screenshot example.
  2. exposed the active stage interface
  3. upgraded and moved the utility classes on the C# side.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 29644
Covered lines: 17245 (58.17%)

New:
Total lines: 29644
Covered lines: 17244 (58.17%)

Diff: -0.00%

[this comment will be updated automatically]

@CBenoit CBenoit changed the title feat(ffi): add screentshot example and the interfaces required to do it feat(ffi): screenshot example using C# bindings Apr 8, 2024
CBenoit
CBenoit reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

ffi/dotnet/Devolutions.IronRdp.ConnectExample/Devolutions.IronRdp.ConnectExample.csproj Outdated Show resolved Hide resolved
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Devolutions.IronRdp.ConnectExample.csproj Outdated Show resolved Hide resolved
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Program.cs Outdated Show resolved Hide resolved
ffi/src/utils/mod.rs Outdated Show resolved Hide resolved
ffi/src/session/mod.rs Outdated Show resolved Hide resolved
ffi/src/session/mod.rs Outdated Show resolved Hide resolved
ffi/src/input.rs Outdated Show resolved Hide resolved
ffi/src/connector/state.rs Outdated Show resolved Hide resolved
ffi/src/connector/mod.rs Outdated Show resolved Hide resolved
ffi/src/connector/mod.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@CBenoit CBenoit merged commit ef20552 into master Apr 9, 2024
7 checks passed
@CBenoit CBenoit deleted the ARC-212-Ironrdp-bindings branch April 9, 2024 14:13
@CBenoit CBenoit mentioned this pull request Apr 9, 2024
Merged
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Apr 22, 2024
Merged
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

@awakecoding awakecoding Awaiting requested review from awakecoding

@thenextman thenextman Awaiting requested review from thenextman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @CBenoit