Skip to content

refactor monorepo tsconfig mapping#320

Merged
fuxingloh merged 27 commits intomainfrom
canonbrother/ts-project-references
Jun 9, 2021
Merged

refactor monorepo tsconfig mapping#320
fuxingloh merged 27 commits intomainfrom
canonbrother/ts-project-references

Conversation

@canonbrother
Copy link
Contributor

@canonbrother canonbrother commented May 31, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Happy dev :)

  1. go to definition will point to source code directly, not .d.ts from /dist.
  2. Don't need to rebuild while updating source code on another package.
    bonus: the build is faster using this approach

Which issue(s) does this PR fixes?:

Fixes #259

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 31, 2021

Code Climate has analyzed commit 924c357 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 31, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 9552b3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60bfae56c565e20007dba893

😎 Browse the preview: https://deploy-preview-320--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented May 31, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 20.15 KB (0%) 403 ms (0%) 169 ms (+49.66% 🔺) 572 ms

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #320 (924c357) into main (3235f31) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   97.09%   97.12%   +0.02%     
==========================================
  Files          93       91       -2     
  Lines        2652     2640      -12     
  Branches      340      339       -1     
==========================================
- Hits         2575     2564      -11     
+ Misses         77       76       -1     
Impacted Files Coverage Δ
...llyfish-transaction-builder/src/txn/txn_builder.ts 96.07% <ø> (ø)
packages/testing/src/poolpair.ts 96.66% <ø> (ø)
...transaction-builder/src/txn/txn_builder_account.ts 100.00% <100.00%> (ø)
...ish-transaction-builder/src/txn/txn_builder_dex.ts 100.00% <100.00%> (ø)
...ransaction-builder/src/txn/txn_builder_liq_pool.ts 100.00% <100.00%> (ø)
...transaction-builder/src/txn/txn_builder_oracles.ts 100.00% <100.00%> (ø)
...ges/jellyfish-transaction/src/script/defi/index.ts 100.00% <100.00%> (ø)
packages/jellyfish-transaction/src/script/index.ts 100.00% <100.00%> (ø)
packages/jellyfish-wallet/src/wallet_account.ts 100.00% <100.00%> (ø)
...llyfish-transaction/__tests__/tx_composer/index.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3235f31...924c357. Read the comment docs.

@canonbrother canonbrother marked this pull request as ready for review June 1, 2021 05:12
@canonbrother canonbrother requested a review from fuxingloh as a code owner June 1, 2021 05:12
@thedoublejay
Copy link
Contributor

great work @canonbrother

@canonbrother canonbrother force-pushed the canonbrother/ts-project-references branch 2 times, most recently from 05158d4 to f8bbb04 Compare June 2, 2021 06:56
@canonbrother canonbrother force-pushed the canonbrother/ts-project-references branch from 9a007db to 6571ba2 Compare June 2, 2021 10:40
@canonbrother

This comment has been minimized.

@fuxingloh fuxingloh self-assigned this Jun 3, 2021
fuxingloh and others added 2 commits June 9, 2021 01:12
* fixed tsconfig.json

* reorder scripts

* fixed exports

* not to collect coverage of tests
@fuxingloh fuxingloh self-requested a review June 9, 2021 03:46
@fuxingloh fuxingloh merged commit 5c29df6 into main Jun 9, 2021
@fuxingloh fuxingloh deleted the canonbrother/ts-project-references branch June 9, 2021 05:30
@fuxingloh fuxingloh changed the title monorepo tsconfig mapping refactor monorepo tsconfig mapping Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

monorepo tsconfig mapping for no build cross repo development

5 participants