-
Notifications
You must be signed in to change notification settings - Fork 477
chore(profiling): improve typing [backport 4.1] #15856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
8948875 to
42612e0
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 3 ms. The average import time from base is: 249 ± 4 ms. The import time difference between this PR and base is: -3.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-15796-to-4.1 (ebfab60) with baseline 4.1 (038b97b) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.183µs (SLO: <20.000µs -9.1%) vs baseline: 📈 +21.4% Memory: ✅ 42.861MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 15.105µs (SLO: <20.000µs 📉 -24.5%) vs baseline: +0.1% Memory: ✅ 42.762MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.1% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 17.895µs (SLO: <30.000µs 📉 -40.4%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.4% ✅ bytearray_extend_aspectTime: ✅ 23.700µs (SLO: <30.000µs 📉 -21.0%) vs baseline: -0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.0% ✅ bytearray_extend_noaspectTime: ✅ 2.673µs (SLO: <10.000µs 📉 -73.3%) vs baseline: +0.7% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ bytearray_noaspectTime: ✅ 1.444µs (SLO: <10.000µs 📉 -85.6%) vs baseline: -1.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 16.656µs (SLO: <20.000µs 📉 -16.7%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 1.402µs (SLO: <10.000µs 📉 -86.0%) vs baseline: -0.2% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 55.076µs (SLO: <70.000µs 📉 -21.3%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 3.216µs (SLO: <10.000µs 📉 -67.8%) vs baseline: +0.8% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ capitalize_aspectTime: ✅ 14.741µs (SLO: <20.000µs 📉 -26.3%) vs baseline: +0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 2.563µs (SLO: <10.000µs 📉 -74.4%) vs baseline: -0.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 14.642µs (SLO: <20.000µs 📉 -26.8%) vs baseline: ~same Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 3.079µs (SLO: <10.000µs 📉 -69.2%) vs baseline: -0.9% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.2% ✅ decode_aspectTime: ✅ 15.461µs (SLO: <30.000µs 📉 -48.5%) vs baseline: -0.6% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.2% ✅ decode_noaspectTime: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.2% ✅ encode_aspectTime: ✅ 18.305µs (SLO: <30.000µs 📉 -39.0%) vs baseline: 📈 +22.8% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.6% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 170.678µs (SLO: <200.000µs 📉 -14.7%) vs baseline: -0.1% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 191.345µs (SLO: <200.000µs -4.3%) vs baseline: +0.2% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.0% ✅ format_map_noaspectTime: ✅ 3.739µs (SLO: <10.000µs 📉 -62.6%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 3.208µs (SLO: <10.000µs 📉 -67.9%) vs baseline: -0.3% Memory: ✅ 42.507MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.1% ✅ index_aspectTime: ✅ 15.230µs (SLO: <20.000µs 📉 -23.8%) vs baseline: -0.4% Memory: ✅ 42.821MB (SLO: <43.250MB 🟡 -1.0%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 16.811µs (SLO: <20.000µs 📉 -15.9%) vs baseline: -0.8% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 1.496µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +0.6% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.5% ✅ ljust_aspectTime: ✅ 20.750µs (SLO: <30.000µs 📉 -30.8%) vs baseline: -0.5% Memory: ✅ 42.821MB (SLO: <43.250MB 🟡 -1.0%) vs baseline: +4.4% ✅ ljust_noaspectTime: ✅ 2.670µs (SLO: <10.000µs 📉 -73.3%) vs baseline: +0.4% Memory: ✅ 42.743MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.828µs (SLO: <30.000µs 📉 -40.6%) vs baseline: +0.2% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 2.373µs (SLO: <10.000µs 📉 -76.3%) vs baseline: -0.2% Memory: ✅ 42.703MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 17.640µs (SLO: <20.000µs 📉 -11.8%) vs baseline: +0.2% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 1.829µs (SLO: <10.000µs 📉 -81.7%) vs baseline: -1.0% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 166.964µs (SLO: <200.000µs 📉 -16.5%) vs baseline: +0.4% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 180.072µs (SLO: <200.000µs -10.0%) vs baseline: +3.1% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +3.9% ✅ modulo_aspect_for_bytesTime: ✅ 168.269µs (SLO: <200.000µs 📉 -15.9%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.952µs (SLO: <200.000µs 📉 -14.0%) vs baseline: +0.1% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.687µs (SLO: <10.000µs 📉 -63.1%) vs baseline: -0.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 214.338µs (SLO: <300.000µs 📉 -28.6%) vs baseline: -0.2% Memory: ✅ 43.057MB (SLO: <44.000MB -2.1%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 5.214µs (SLO: <10.000µs 📉 -47.9%) vs baseline: +0.5% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.0% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.523µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.3% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 18.943µs (SLO: <30.000µs 📉 -36.9%) vs baseline: -0.8% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ rstrip_noaspectTime: ✅ 1.900µs (SLO: <10.000µs 📉 -81.0%) vs baseline: +0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 15.948µs (SLO: <20.000µs 📉 -20.3%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.2% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 53.747µs (SLO: <80.000µs 📉 -32.8%) vs baseline: -0.1% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ stringio_noaspectTime: ✅ 3.532µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 17.617µs (SLO: <20.000µs 📉 -11.9%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 1.833µs (SLO: <10.000µs 📉 -81.7%) vs baseline: +0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 18.325µs (SLO: <30.000µs 📉 -38.9%) vs baseline: -0.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ swapcase_noaspectTime: ✅ 2.751µs (SLO: <10.000µs 📉 -72.5%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.2% ✅ title_aspectTime: ✅ 18.186µs (SLO: <30.000µs 📉 -39.4%) vs baseline: +0.2% Memory: ✅ 42.821MB (SLO: <43.000MB 🟡 -0.4%) vs baseline: +4.4% ✅ title_noaspectTime: ✅ 2.639µs (SLO: <10.000µs 📉 -73.6%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 23.904µs (SLO: <30.000µs 📉 -20.3%) vs baseline: 📈 +17.6% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.247µs (SLO: <10.000µs 📉 -57.5%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 17.882µs (SLO: <30.000µs 📉 -40.4%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 2.366µs (SLO: <10.000µs 📉 -76.3%) vs baseline: -0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.271µs (SLO: <10.000µs 📉 -47.3%) vs baseline: 📈 +22.1% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 4.410µs (SLO: <10.000µs 📉 -55.9%) vs baseline: +0.2% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.223µs (SLO: <10.000µs 📉 -37.8%) vs baseline: +0.2% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 6.304µs (SLO: <10.000µs 📉 -37.0%) vs baseline: -0.8% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.624µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.3% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.707µs (SLO: <10.000µs 📉 -62.9%) vs baseline: -0.4% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.2% ✅ ospathsplit_aspectTime: ✅ 4.960µs (SLO: <10.000µs 📉 -50.4%) vs baseline: -0.9% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 5.097µs (SLO: <10.000µs 📉 -49.0%) vs baseline: -0.1% Memory: ✅ 41.327MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.843µs (SLO: <10.000µs 📉 -61.6%) vs baseline: -0.1% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.752µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -1.1% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.685µs (SLO: <10.000µs 📉 -53.1%) vs baseline: -0.3% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 4.748µs (SLO: <10.000µs 📉 -52.5%) vs baseline: -0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.1% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
42612e0 to
d3da0e6
Compare
d3da0e6 to
ebfab60
Compare
Backport 929596a from #15796 to 4.1.
Description
This improves typing in a test file.
Related