-
Notifications
You must be signed in to change notification settings - Fork 477
chore(profiling): improve typing #15814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): improve typing #15814
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate kowalski/chore-profiling-improve-typing-in-tests-2 (7547453) with baseline main (929596a) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.034µs (SLO: <20.000µs -9.8%) vs baseline: 📈 +21.0% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 14.985µs (SLO: <20.000µs 📉 -25.1%) vs baseline: +0.5% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.339µs (SLO: <10.000µs 📉 -96.6%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.551µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +1.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 17.939µs (SLO: <30.000µs 📉 -40.2%) vs baseline: +0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 24.012µs (SLO: <30.000µs 📉 -20.0%) vs baseline: -0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 2.761µs (SLO: <10.000µs 📉 -72.4%) vs baseline: +0.8% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.463µs (SLO: <10.000µs 📉 -85.4%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 16.516µs (SLO: <20.000µs 📉 -17.4%) vs baseline: -0.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 1.405µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -1.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 55.191µs (SLO: <70.000µs 📉 -21.2%) vs baseline: -0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 3.280µs (SLO: <10.000µs 📉 -67.2%) vs baseline: +1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 14.646µs (SLO: <20.000µs 📉 -26.8%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 2.577µs (SLO: <10.000µs 📉 -74.2%) vs baseline: -0.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.643µs (SLO: <20.000µs 📉 -26.8%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.176µs (SLO: <10.000µs 📉 -68.2%) vs baseline: +1.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 15.678µs (SLO: <30.000µs 📉 -47.7%) vs baseline: +0.9% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 18.161µs (SLO: <30.000µs 📉 -39.5%) vs baseline: 📈 +23.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.500µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 170.875µs (SLO: <200.000µs 📉 -14.6%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.5% ✅ format_map_aspectTime: ✅ 190.814µs (SLO: <200.000µs -4.6%) vs baseline: -0.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 3.797µs (SLO: <10.000µs 📉 -62.0%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.195µs (SLO: <10.000µs 📉 -68.1%) vs baseline: ~same Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.6% ✅ index_aspectTime: ✅ 15.446µs (SLO: <20.000µs 📉 -22.8%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 17.117µs (SLO: <20.000µs 📉 -14.4%) vs baseline: +0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 1.541µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -1.3% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.794µs (SLO: <30.000µs 📉 -30.7%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 2.722µs (SLO: <10.000µs 📉 -72.8%) vs baseline: +0.5% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 17.889µs (SLO: <30.000µs 📉 -40.4%) vs baseline: -0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 2.424µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +0.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 17.684µs (SLO: <30.000µs 📉 -41.1%) vs baseline: +0.4% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 1.869µs (SLO: <10.000µs 📉 -81.3%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 166.743µs (SLO: <200.000µs 📉 -16.6%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 180.297µs (SLO: <200.000µs -9.9%) vs baseline: +3.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.2% ✅ modulo_aspect_for_bytesTime: ✅ 168.516µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.954µs (SLO: <200.000µs 📉 -14.0%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.4% ✅ modulo_noaspectTime: ✅ 3.667µs (SLO: <10.000µs 📉 -63.3%) vs baseline: -1.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 212.270µs (SLO: <300.000µs 📉 -29.2%) vs baseline: +0.2% Memory: ✅ 42.664MB (SLO: <44.000MB -3.0%) vs baseline: +4.5% ✅ replace_noaspectTime: ✅ 2.919µs (SLO: <10.000µs 📉 -70.8%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 1.411µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.526µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -1.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 19.033µs (SLO: <30.000µs 📉 -36.6%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 2.065µs (SLO: <10.000µs 📉 -79.3%) vs baseline: +6.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.936µs (SLO: <20.000µs 📉 -20.3%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 53.929µs (SLO: <80.000µs 📉 -32.6%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 3.673µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +1.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 17.610µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 1.881µs (SLO: <10.000µs 📉 -81.2%) vs baseline: -0.2% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 18.416µs (SLO: <30.000µs 📉 -38.6%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 2.823µs (SLO: <10.000µs 📉 -71.8%) vs baseline: +0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 18.148µs (SLO: <30.000µs 📉 -39.5%) vs baseline: -0.7% Memory: ✅ 42.585MB (SLO: <43.000MB 🟡 -1.0%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 2.684µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +1.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 24.325µs (SLO: <30.000µs 📉 -18.9%) vs baseline: 📈 +18.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.335µs (SLO: <10.000µs 📉 -56.6%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 17.922µs (SLO: <30.000µs 📉 -40.3%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 2.450µs (SLO: <10.000µs 📉 -75.5%) vs baseline: -0.8% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.175µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +21.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 4.291µs (SLO: <10.000µs 📉 -57.1%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.274µs (SLO: <10.000µs 📉 -37.3%) vs baseline: -0.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 6.362µs (SLO: <10.000µs 📉 -36.4%) vs baseline: +0.4% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.580µs (SLO: <10.000µs 📉 -64.2%) vs baseline: -0.8% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.638µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.972µs (SLO: <10.000µs 📉 -50.3%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 5.032µs (SLO: <10.000µs 📉 -49.7%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.786µs (SLO: <10.000µs 📉 -62.1%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.745µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.628µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 4.661µs (SLO: <10.000µs 📉 -53.4%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.2% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.449µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +16.2% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.4% ✅ 1-count-metrics-100-timesTime: ✅ 199.922µs (SLO: <220.000µs -9.1%) vs baseline: +0.2% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.3% ✅ 1-distribution-metric-1-timesTime: ✅ 3.365µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +1.2% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.364µs (SLO: <230.000µs -6.8%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.188µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.760µs (SLO: <150.000µs -8.2%) vs baseline: +0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.169µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +1.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.770µs (SLO: <250.000µs 📉 -14.5%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.069ms (SLO: <22.000ms -8.8%) vs baseline: +1.1% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.550ms 📉 -12.7%) vs baseline: -0.7% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.403ms (SLO: <1.550ms -9.5%) vs baseline: -0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.172ms (SLO: <2.550ms 📉 -14.8%) vs baseline: -0.1% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.4% ✅ flush-1-metricTime: ✅ 4.559µs (SLO: <20.000µs 📉 -77.2%) vs baseline: ~same Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 174.832µs (SLO: <250.000µs 📉 -30.1%) vs baseline: -0.2% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.180ms (SLO: <2.500ms 📉 -12.8%) vs baseline: ~same Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.6% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
91ff9ba to
7547453
Compare
## Description As title says, one more typing PR!
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.19 3.19
# Navigate to the new working tree
cd .worktrees/backport-3.19
# Create a new branch
git switch --create backport-15814-to-3.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a2d9db9c5c882f91abe0dacc99a0121a058f70a
# Push it to GitHub
git push --set-upstream origin backport-15814-to-3.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.0 4.0
# Navigate to the new working tree
cd .worktrees/backport-4.0
# Create a new branch
git switch --create backport-15814-to-4.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a2d9db9c5c882f91abe0dacc99a0121a058f70a
# Push it to GitHub
git push --set-upstream origin backport-15814-to-4.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.0Then, create a pull request where the |
## Description As title says, one more typing PR! (cherry picked from commit 0a2d9db)
Backport 929596a from #15796 to 4.1. ## Description This improves typing in a test file. Related - #15797 - #15814 Co-authored-by: Thomas Kowalski <[email protected]>
## Description As title says, one more typing PR! (cherry picked from commit 0a2d9db)
## Description As title says, one more typing PR! (cherry picked from commit 0a2d9db)
## Description As title says, one more typing PR! (cherry picked from commit 0a2d9db)
## Description As title says, one more typing PR!
## Description This PR unflakes `test_gunicorn` after DataDog#15814 made it flaky. The problem is that DataDog#15814 shifted the line we wanted to see in profiles by 4 lines, making the expected location much rarer.
## Description As title says, one more typing PR! (cherry picked from commit 0a2d9db)
As title says, one more typing PR! (cherry picked from commit 0a2d9db)
Backport 0a2d9db from #15814 to 4.1. ## Description As title says, one more typing PR! Co-authored-by: Thomas Kowalski <[email protected]>
Description
As title says, one more typing PR!