WIP - delay starting OkHttp #8276
Draft
+56
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045645
Total [baseline] (8.645 s) : 0, 8645167
Agent [candidate] (1.037 s) : 0, 1037384
Total [candidate] (8.644 s) : 0, 8644048
section iast
Agent [baseline] (1.162 s) : 0, 1162132
Total [baseline] (9.211 s) : 0, 9211111
Agent [candidate] (1.166 s) : 0, 1166202
Total [candidate] (9.232 s) : 0, 9232264
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174761
Total [baseline] (9.174 s) : 0, 9174286
Agent [candidate] (1.167 s) : 0, 1166628
Total [candidate] (9.143 s) : 0, 9143376
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1160365
Total [baseline] (9.212 s) : 0, 9211944
Agent [candidate] (1.177 s) : 0, 1177161
Total [candidate] (9.258 s) : 0, 9258382
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.308 ms) : 0, 721308
BytebuddyAgent [candidate] (714.476 ms) : 0, 714476
GlobalTracer [baseline] (240.658 ms) : 0, 240658
GlobalTracer [candidate] (239.171 ms) : 0, 239171
AppSec [baseline] (55.561 ms) : 0, 55561
AppSec [candidate] (55.44 ms) : 0, 55440
Remote Config [baseline] (723.447 µs) : 0, 723
Remote Config [candidate] (709.813 µs) : 0, 710
Telemetry [baseline] (12.205 ms) : 0, 12205
Telemetry [candidate] (12.331 ms) : 0, 12331
section iast
BytebuddyAgent [baseline] (830.182 ms) : 0, 830182
BytebuddyAgent [candidate] (832.717 ms) : 0, 832717
GlobalTracer [baseline] (228.6 ms) : 0, 228600
GlobalTracer [candidate] (229.732 ms) : 0, 229732
AppSec [baseline] (57.004 ms) : 0, 57004
AppSec [candidate] (57.828 ms) : 0, 57828
IAST [baseline] (21.983 ms) : 0, 21983
IAST [candidate] (21.283 ms) : 0, 21283
Remote Config [baseline] (645.611 µs) : 0, 646
Remote Config [candidate] (666.845 µs) : 0, 667
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.659 ms) : 0, 8659
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.2 ms) : 0, 839200
BytebuddyAgent [candidate] (833.297 ms) : 0, 833297
GlobalTracer [baseline] (230.861 ms) : 0, 230861
GlobalTracer [candidate] (229.022 ms) : 0, 229022
AppSec [baseline] (58.831 ms) : 0, 58831
AppSec [candidate] (58.291 ms) : 0, 58291
IAST [baseline] (21.158 ms) : 0, 21158
IAST [candidate] (21.41 ms) : 0, 21410
Remote Config [baseline] (653.555 µs) : 0, 654
Remote Config [candidate] (640.874 µs) : 0, 641
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (8.722 ms) : 0, 8722
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.577 ms) : 0, 828577
BytebuddyAgent [candidate] (841.139 ms) : 0, 841139
GlobalTracer [baseline] (228.598 ms) : 0, 228598
GlobalTracer [candidate] (231.462 ms) : 0, 231462
AppSec [baseline] (58.094 ms) : 0, 58094
AppSec [candidate] (58.419 ms) : 0, 58419
IAST [baseline] (20.858 ms) : 0, 20858
IAST [candidate] (21.255 ms) : 0, 21255
Remote Config [baseline] (653.181 µs) : 0, 653
Remote Config [candidate] (676.323 µs) : 0, 676
Telemetry [baseline] (8.659 ms) : 0, 8659
Telemetry [candidate] (8.76 ms) : 0, 8760
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036063
Total [baseline] (10.445 s) : 0, 10444602
Agent [candidate] (1.041 s) : 0, 1040947
Total [candidate] (10.518 s) : 0, 10517984
section appsec
Agent [baseline] (1.178 s) : 0, 1177509
Total [baseline] (10.705 s) : 0, 10705037
Agent [candidate] (1.177 s) : 0, 1177081
Total [candidate] (10.696 s) : 0, 10696012
section iast
Agent [baseline] (1.169 s) : 0, 1168588
Total [baseline] (10.965 s) : 0, 10964575
Agent [candidate] (1.17 s) : 0, 1170015
Total [candidate] (10.984 s) : 0, 10983539
section profiling
Agent [baseline] (1.277 s) : 0, 1277360
Total [baseline] (10.829 s) : 0, 10828979
Agent [candidate] (1.253 s) : 0, 1252847
Total [candidate] (10.88 s) : 0, 10880359
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.473 ms) : 0, 713473
BytebuddyAgent [candidate] (717.263 ms) : 0, 717263
GlobalTracer [baseline] (238.479 ms) : 0, 238479
GlobalTracer [candidate] (239.869 ms) : 0, 239869
AppSec [baseline] (56.335 ms) : 0, 56335
AppSec [candidate] (55.601 ms) : 0, 55601
Remote Config [baseline] (709.741 µs) : 0, 710
Remote Config [candidate] (707.389 µs) : 0, 707
Telemetry [baseline] (12.085 ms) : 0, 12085
Telemetry [candidate] (12.198 ms) : 0, 12198
section appsec
BytebuddyAgent [baseline] (731.616 ms) : 0, 731616
BytebuddyAgent [candidate] (731.263 ms) : 0, 731263
GlobalTracer [baseline] (236.327 ms) : 0, 236327
GlobalTracer [candidate] (235.698 ms) : 0, 235698
AppSec [baseline] (176.124 ms) : 0, 176124
AppSec [candidate] (176.043 ms) : 0, 176043
IAST [baseline] (19.297 ms) : 0, 19297
IAST [candidate] (19.233 ms) : 0, 19233
Remote Config [baseline] (660.159 µs) : 0, 660
Remote Config [candidate] (663.433 µs) : 0, 663
Telemetry [baseline] (8.176 ms) : 0, 8176
Telemetry [candidate] (8.531 ms) : 0, 8531
section iast
BytebuddyAgent [baseline] (834.595 ms) : 0, 834595
BytebuddyAgent [candidate] (834.334 ms) : 0, 834334
GlobalTracer [baseline] (230.188 ms) : 0, 230188
GlobalTracer [candidate] (230.577 ms) : 0, 230577
AppSec [baseline] (57.278 ms) : 0, 57278
AppSec [candidate] (58.595 ms) : 0, 58595
IAST [baseline] (22.088 ms) : 0, 22088
IAST [candidate] (21.597 ms) : 0, 21597
Remote Config [baseline] (662.221 µs) : 0, 662
Remote Config [candidate] (666.525 µs) : 0, 667
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.923 ms) : 0, 8923
section profiling
BytebuddyAgent [baseline] (717.545 ms) : 0, 717545
BytebuddyAgent [candidate] (703.619 ms) : 0, 703619
GlobalTracer [baseline] (353.805 ms) : 0, 353805
GlobalTracer [candidate] (348.981 ms) : 0, 348981
AppSec [baseline] (55.745 ms) : 0, 55745
AppSec [candidate] (53.711 ms) : 0, 53711
Remote Config [baseline] (740.435 µs) : 0, 740
Remote Config [candidate] (720.897 µs) : 0, 721
Telemetry [baseline] (9.027 ms) : 0, 9027
Telemetry [candidate] (8.827 ms) : 0, 8827
ProfilingAgent [baseline] (97.732 ms) : 0, 97732
ProfilingAgent [candidate] (94.674 ms) : 0, 94674
Profiling [baseline] (97.757 ms) : 0, 97757
Profiling [candidate] (94.698 ms) : 0, 94698
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1379
. : milestone, 1359,
appsec (1.728 ms) : 1705, 1752
. : milestone, 1728,
appsec_no_iast (1.758 ms) : 1732, 1784
. : milestone, 1758,
iast (1.503 ms) : 1479, 1527
. : milestone, 1503,
profiling (1.502 ms) : 1479, 1526
. : milestone, 1502,
tracing (1.494 ms) : 1469, 1518
. : milestone, 1494,
section candidate
no_agent (1.363 ms) : 1343, 1383
. : milestone, 1363,
appsec (1.751 ms) : 1727, 1774
. : milestone, 1751,
appsec_no_iast (1.754 ms) : 1730, 1779
. : milestone, 1754,
iast (1.513 ms) : 1490, 1537
. : milestone, 1513,
profiling (1.558 ms) : 1533, 1583
. : milestone, 1558,
tracing (1.476 ms) : 1450, 1501
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section baseline
no_agent (380.098 µs) : 360, 400
. : milestone, 380,
iast (511.05 µs) : 489, 533
. : milestone, 511,
iast_FULL (740.524 µs) : 718, 764
. : milestone, 741,
iast_GLOBAL (558.861 µs) : 535, 582
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (514.332 µs) : 491, 538
. : milestone, 514,
iast_INACTIVE (454.178 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (493.916 µs) : 471, 517
. : milestone, 494,
tracing (442.625 µs) : 422, 463
. : milestone, 443,
section candidate
no_agent (376.296 µs) : 357, 396
. : milestone, 376,
iast (507.137 µs) : 485, 530
. : milestone, 507,
iast_FULL (735.446 µs) : 713, 758
. : milestone, 735,
iast_GLOBAL (561.653 µs) : 538, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (511.676 µs) : 488, 535
. : milestone, 512,
iast_INACTIVE (454.258 µs) : 433, 476
. : milestone, 454,
iast_TELEMETRY_OFF (498.61 µs) : 475, 522
. : milestone, 499,
tracing (449.096 µs) : 429, 470
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.346 ms) : 2303, 2389
. : milestone, 2346,
iast (2.094 ms) : 2039, 2148
. : milestone, 2094,
iast_GLOBAL (2.146 ms) : 2091, 2201
. : milestone, 2146,
profiling (2.455 ms) : 2266, 2644
. : milestone, 2455,
tracing (1.941 ms) : 1899, 1983
. : milestone, 1941,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.353 ms) : 2311, 2396
. : milestone, 2353,
iast (2.101 ms) : 2046, 2155
. : milestone, 2101,
iast_GLOBAL (2.137 ms) : 2083, 2192
. : milestone, 2137,
profiling (1.964 ms) : 1920, 2007
. : milestone, 1964,
tracing (1.931 ms) : 1890, 1973
. : milestone, 1931,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d033330727, baseline=1.46.0-SNAPSHOT~f701ba9d75
dateFormat X
axisFormat %s
section baseline
no_agent (15.487 s) : 15487000, 15487000
. : milestone, 15487000,
appsec (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
iast (18.79 s) : 18790000, 18790000
. : milestone, 18790000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
section candidate
no_agent (15.623 s) : 15623000, 15623000
. : milestone, 15623000,
appsec (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
iast (18.895 s) : 18895000, 18895000
. : milestone, 18895000,
iast_GLOBAL (18.244 s) : 18244000, 18244000
. : milestone, 18244000,
profiling (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
|
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
5 times, most recently
from
86f7cae to
dffe2ac
Compare
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
dffe2ac to
e7ae79b
Compare
mcculls
changed the title
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
e7ae79b to
1c050d0
Compare
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
2 times, most recently
from
2af2a09 to
c51a05c
Compare
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
c51a05c to
8090724
Compare
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
6210f36 to
1b56d50
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| */ | ||
| static byte[] concatLengthPrefixed(List<Protocol> protocols) { | ||
| Buffer result = new Buffer(); | ||
| for (int i = 0, size = protocols.size(); i < size; i++) { |
There was a problem hiding this comment.
🟠 Code Quality Violation
Too many control variables can make it difficult to reason about (...read more)
The presence of multiple control variables in a for loop can obscure the range of values over which the loop iterates and make your code brittle and difficult to debug.
To follow this rule, regular for loops should have only one control variable.
| @@ -80,6 +81,7 @@ public class DDAgentFeaturesDiscovery implements DroppingPolicy { | |||
| private volatile String telemetryProxyEndpoint; | |||
|
|
|||
| private long lastTimeDiscovered; | |||
| private MessageDigest sha256; | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Avoid declaring a field of MessageDigest type as unsynchronized access could cause problems (...read more)
When you designate a MessageDigest instance as a class member, you enable direct access for multiple threads in your program. It is important to exercise caution when sharing instances among threads without proper synchronization.
Instead of sharing a single MessageDigest instance, consider generating new instances when necessary and using them locally within the specific context where they are needed. This practice offers two benefits. First, it guarantees that each thread operates on its own instance, thereby minimizing the possibility of interference between threads. Second, it sidesteps the intricacies of managing synchronized access to a shared instance.
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
69ea585 to
9092481
Compare
mcculls
force-pushed
the
mcculls/delay-starting-okhttp
branch
from
9092481 to
d033330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]