[pkg/otlp/model] Backport translator changes#9789
Merged
Conversation
6cbffb1 to
a169c56
Compare
mx-psi
commented
Nov 8, 2021
| delta := md.Histogram().AggregationTemporality() == pdata.MetricAggregationTemporalityDelta | ||
| t.mapHistogramMetrics(ctx, consumer, md.Name(), md.Histogram().DataPoints(), delta, additionalTags, host) | ||
| default: // pdata.MetricAggregationTemporalityUnspecified or any other not supported type | ||
| default: // pdata.AggregationTemporalityUnspecified or any other not supported type |
Member
Author
There was a problem hiding this comment.
This and the comment above were changed on #9398 but are still unchanged on the contrib repo
| } | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This comes from open-telemetry/opentelemetry-collector-contrib/pull/5315
albertvaka
approved these changes
Nov 8, 2021
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
* [pkg/otlp/model] Backport recent changes in the Datadog exporter * Add release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR backports two recent changes on the OpenTelemetry Collector Datadog exporter version of this module:
Motivation
Keep the two versions in sync until we can drop the code from the Datadog exporter side.
Additional Notes
To do this I copied the code from the main branch on the Collector and replaced the imports. diff between the translator code and the Collector translator code as of commit open-telemetry/opentelemetry-collector-contrib@e066c9c:
Describe how to test your changes
To test open-telemetry/opentelemetry-collector-contrib#6120:
HistogramandCounterinstruments with default settings).One can also add a negative amount with the
countershistogram mode and check that the sum is non0.open-telemetry/opentelemetry-collector-contrib#5885 doesn't need testing (only adds unit tests on this module)
Checklist
changelog/no-changeloglabel has been applied.need-change/operatorandneed-change/helmlabels has been applied if applicable.team/..label has been applied, if known.Triagemilestone is set.Note: Adding GitHub labels is only possible for contributors with write access.