[exporter/datadogexporter] Use a Consumer interface for decoupling from zorkian's package#5315
Merged
bogdandrutu merged 9 commits intoOct 15, 2021
Conversation
mx-psi
force-pushed
the
mx-psi/use-store-interface
branch
2 times, most recently
from
32db07a to
0499a8e
Compare
KSerrania
approved these changes
Sep 22, 2021
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
Left two comments, but otherwise LGTM
KSerrania
approved these changes
Sep 23, 2021
mx-psi
force-pushed
the
mx-psi/use-store-interface
branch
from
2bf0b97 to
8a3d299
Compare
mx-psi
force-pushed
the
mx-psi/use-store-interface
branch
2 times, most recently
from
7f81efb to
1686b0e
Compare
mx-psi
force-pushed
the
mx-psi/use-store-interface
branch
from
1686b0e to
7f25329
Compare
mx-psi
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 24, 2021
mx-psi
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 27, 2021
* [exporter/datadogexporter] Copy main branch contents * Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270) * Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315) * Make tests pass
This adds a comment added originally on: - DataDog/datadog-agent@a258ba7,
Member
Author
|
@KSerrania mind having one last look? One 'easy' way to make sure everything is okay is by doing a |
anuraaga
approved these changes
Oct 6, 2021
Member
|
Please rebase |
Member
Author
|
@KSerrania ping |
KSerrania
approved these changes
Oct 14, 2021
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
LGTM, I also checked the diff between exporter/datadogexporter/internal/translator here and pkg/otlp/model/translator in datadog-agent and it looks good to me.
mx-psi
added
the
ready to merge
bogdandrutu
approved these changes
Oct 15, 2021
5 tasks
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…emetry#5315) Signed-off-by: Kevin Earls <kearls@redhat.com>
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
* [exporter/datadogexporter] Copy main branch contents * Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270) * Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315) * Make tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Creates a
Consumerinterface that consumes timeseries and sketches metrics.Splits zorkian's specific code into this new interface.
Testing: Amended unit tests. Tested with end to end unit testing.
Documentation: n/a this is an internal refactor with no visible user changes.