[datadogexporter] [Breaking change] Make distributions the default histogram export option#5885
Merged
bogdandrutu merged 2 commits intoOct 27, 2021
Conversation
mx-psi
reviewed
Oct 25, 2021
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
I would mention somewhere (PR title?) that this is a breaking change, so that it gets reflected properly on the changelog
KSerrania
changed the title
mx-psi
approved these changes
Oct 25, 2021
mx-psi
added
ready to merge
mx-psi
requested changes
Oct 26, 2021
mx-psi
approved these changes
Oct 27, 2021
mx-psi
added
the
ready to merge
This was referenced Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes the default histogram export option to distributions + removes count and sum metrics by default (breaking change: by default, only count and sum metrics were sent for histograms).
Refactors the metric translator unit tests to cover all valid histogram cases.
Link to tracking Issue: n/a
Testing: Amended & updated unit tests.
Documentation: Inline docs & example config files.