Vitest browser cleanup #3344

[Dargon789]

Summary by Sourcery

Refactor and clean up code across multiple packages, update documentation, and adjust CI workflows.

Enhancements:

• Replace deprecated toBytes utility function with specific converters like hexToBytes and intToBytes.
• Refactor account and deposit log parsing logic for improved clarity and validation.
• Use centralized EVMError.errorMessages instead of direct string literals.

CI:

• Update Docker build workflow.
• Add a new workflow for deploying GitHub Pages documentation.
• Update test configurations.

Documentation:

• Update READMEs for all packages to include a table of contents and reflect v10 changes.

Tests:

• Update tests to align with code refactoring and use new utility functions.
• Add new tests for Consensus Layer (CL) requests.
• Refactor test data handling.

Chores:

• Update package-lock.json and Node version file (.nvmrc).
• Update @noble/curves dependency.
• Remove unused test data files.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request includes extensive updates to the README files across multiple EthereumJS packages, focusing on improving clarity, reorganizing content, updating examples, and bumping versions to v10. In parallel, the codebase sees significant changes aimed at improving type safety and consistency, standardizing error handling within the EVM, and general code cleanup and refactoring.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Updated README files across numerous packages	Updated version numbers to v10 Reorganized and updated Table of Contents Expanded and clarified sections like 'Getting Started', 'Usage', 'Examples', 'API', and EIP/Hardfork support Added new examples and updated existing ones Removed deprecated notes and sections Improved overall formatting and corrected typos	packages/evm/README.md packages/util/README.md packages/vm/README.md packages/statemanager/README.md packages/tx/README.md packages/block/README.md packages/era/README.md packages/devp2p/README.md packages/mpt/README.md packages/verkle/README.md packages/rlp/README.md packages/ethash/README.md packages/binarytree/README.md packages/wallet/README.md
Improved type safety and consistency in code	Replaced generic toBytes calls with specific hexToBytes or intToBytes Added and refined type hints for various data structures and parameters Improved handling and validation of byte array inputs Updated RLP decoding/encoding logic to handle specific types	packages/util/test/account.spec.ts packages/util/src/account.ts packages/vm/src/requests.ts packages/common/src/gethGenesis.ts packages/statemanager/src/statefulVerkleStateManager.ts packages/tx/src/types.ts packages/util/src/bytes.ts packages/statemanager/src/statefulBinaryTreeStateManager.ts packages/tx/src/legacy/tx.ts packages/vm/examples/run-solidity-contract.ts packages/block/src/block/constructors.ts packages/blockchain/test/index.spec.ts packages/util/src/signature.ts packages/util/src/verkle.ts packages/util/test/address.spec.ts packages/util/test/types.spec.ts packages/verkle/test/util.spec.ts packages/vm/test/t8n/stateTracker.ts packages/vm/test/t8n/t8ntool.ts packages/vm/test/tester/runners/BlockchainTestsRunner.ts packages/client/test/sync/fetcher/accountfetcher.spec.ts packages/client/test/sync/fetcher/storagefetcher.spec.ts packages/client/test/rpc/eth/getFeeHistory.spec.ts packages/mpt/test/proof/range.spec.ts packages/mpt/test/trie/trie.spec.ts packages/statemanager/src/statelessVerkleStateManager.ts packages/util/src/binaryTree.ts packages/vm/test/api/customChain.spec.ts packages/vm/test/api/events.spec.ts packages/client/bin/utils.ts packages/client/test/integration/miner.spec.ts packages/client/test/miner/miner.spec.ts packages/client/test/sync/skeleton.spec.ts packages/client/src/net/peerpool.ts packages/client/src/rpc/engine/engine.ts packages/client/test/sim/snapsync.spec.ts packages/testdata/src/gethGenesis/withdrawalsGethGenesis.ts packages/tx/examples/custom-chain-id-tx.ts packages/testdata/src/gethGenesis/invalidSpuriousDragonGethGenesis.ts packages/evm/test/eips/eip-5450.spec.ts packages/evm/test/eips/eip-5656.spec.ts packages/client/src/rpc/modules/web3.ts packages/client/test/rpc/admin/addPeer.spec.ts
Standardized EVM error handling	Adopted consistent usage of EVMError.errorMessages constants Introduced EVMErrorResult helper function Removed duplicated or unused error message constants	packages/evm/src/opcodes/functions.ts packages/evm/src/eof/errors.ts packages/evm/src/stack.ts packages/evm/src/evm.ts packages/evm/src/precompiles/* packages/evm/test/runCall.spec.ts packages/evm/src/opcodes/EIP2200.ts packages/evm/src/opcodes/util.ts packages/vm/test/api/istanbul/eip-1344.spec.ts packages/vm/test/api/istanbul/eip-1884.spec.ts packages/evm/src/precompiles/bls12_381/mcl.ts packages/evm/src/precompiles/bls12_381/noble.ts
Performed general code cleanup and refactoring	Simplified partial account RLP decoding Removed unnecessary byte conversions Deprecated direct Account constructor usage Removed duplicated error messages	packages/util/src/account.ts packages/evm/src/eof/errors.ts packages/util/src/bytes.ts packages/mpt/src/util/nibbles.ts packages/mpt/src/util/encoding.ts packages/client/src/rpc/modules/web3.ts
Updated examples and test data usage	Migrated examples and tests to use new structured test data imports Added a new example for EIP-7685 CL Requests	packages/vm/examples/runGoerliBlock.ts packages/vm/examples/helpers/blockchain-mock-data.ts packages/block/examples/clrequests.ts packages/testdata/src/blocks/preLondonTestDataBlocks2RLP.ts packages/testdata/src/blocks/preLondonTestDataBlocks1RLP.ts packages/testdata/src/blocks/index.ts packages/blockchain/test/index.spec.ts packages/vm/test/api/EIPs/eip-2935-historical-block-hashes.spec.ts packages/vm/examples/vmWithEIPs.ts packages/evm/examples/eips.ts packages/vm/examples/vmWith4844.ts packages/vm/test/api/runBlock.spec.ts packages/block/examples/1559.ts packages/block/test/header.spec.ts packages/client/test/sim/snapsync.spec.ts packages/vm/examples/vmWithGenesisState.ts
Updated CI/CD workflows	Updated Docker image tag in workflow Added new workflow for Jekyll documentation deployment	.github/workflows/docker-image.yml .github/workflows/jekyll-gh-pages.yml .nvmrc

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[sourcery-ai]

Hey @Dargon789 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The PR title doesn't reflect the extensive scope of changes beyond browser testing cleanup.
• Ensure formatting and detail level are consistent across all updated README files.
• Consider splitting large refactorings like this into smaller, more focused PRs for easier review.

Here's what I looked at during the review

• 🟡 General issues: 4 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ethereumjs-monorepo-zmjp	❌ Failed (Inspect)			Apr 26, 2025 1:07am
vite	❌ Failed (Inspect)			Apr 26, 2025 1:07am