Vitest browser cleanup #3344

[Dargon789]

Summary by Sourcery

Refactor error handling, improve type safety, and update documentation across multiple packages for v10 release.

Bug Fixes:

• Add stricter validation for deposit log parsing in vm/requests.ts.
• Fix potential null pointer errors in client PeerPool and AccountFetcher.
• Correct bytesToHex handling for empty input.
• Add missing alloc property to genesis data in client tests.
• Ensure consistent error handling in BLS precompile 10.

Enhancements:

• Standardize EVM error message handling using EVMError.errorMessages.
• Improve type safety using PrefixedHexString and specific *ToBytes functions (hexToBytes, intToBytes, bigIntToBytes).
• Refactor util/account.ts partial account RLP decoding for simplicity and robustness.
• Refactor test and example data handling from JSON to TypeScript files.
• Refactor EVM error definitions and index exports for clarity.
• Refactor various utility functions (bytes, signature, verkle, binaryTree) for consistency.

Build:

• Add .nvmrc file to specify Node.js version.
• Update ethash test script configuration.

CI:

• Add GitHub Actions workflow for Jekyll site deployment.
• Update target repository for Docker image publication.github-actions Docker image workflow target repository.yml Docker image push target repository.

Documentation:

• Update READMEs across most packages with Table of Contents, v10 version markers, and refreshed content.
• Add example for EIP-7685 Consensus Layer requests.

Tests:

• Update tests to align with refactored error handling and type safety improvements.
• Adapt tests for changes in partial account RLP decoding.
• Refactor test data imports to use TypeScript modules.
• Add tests for EIP-7685 CL requests.
• Update various client, VM, and utility tests for consistency and fixes.
• Remove obsolete test files.

Chores:

• Update dependencies, including @noble/curves.
• Deprecate direct Account constructor.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request updates documentation across multiple EthereumJS packages for the v10 release, refactors utility functions for improved type handling and byte conversions, standardizes EVM error access, updates test data usage, and includes minor fixes and dependency updates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Update documentation across multiple packages for the v10 release.	Update version numbers in README titles to v10. Add or update Table of Contents sections. Reorder and rename sections like 'Usage' to 'Getting Started'. Add/update 'WASM Crypto Support' and 'Browser' sections. Update documentation for EIP-4844 and EIP-7702. Add documentation for EIP-7685 and EIP-2935. Remove deprecated constructor usage notes. Add example for CLRequests in @ethereumjs/block README. Update account module description in @ethereumjs/util README. Remove 'Provider Engine' section from @ethereumjs/wallet README.	packages/evm/README.md packages/vm/README.md packages/statemanager/README.md packages/tx/README.md packages/util/README.md packages/block/README.md packages/era/README.md packages/devp2p/README.md packages/mpt/README.md packages/verkle/README.md packages/binarytree/README.md packages/rlp/README.md packages/ethash/README.md packages/wallet/README.md
Refine utility functions and account RLP handling in @ethereumjs/util.	Replace old byte conversion functions with new ones (e.g., toBytes with intToBytes or hexToBytes). Add handleNullIndicator function for RLP-encoded partial accounts. Update createPartialAccountFromRLP to use handleNullIndicator. Mark Account constructor as deprecated. Improve type hints for byte and account data. Standardize hex string handling with PrefixedHexString type. Update intToHex and intToBytes to throw on invalid input. Update signature handling to use new byte conversion functions.	packages/util/test/account.spec.ts packages/util/src/account.ts packages/util/src/bytes.ts packages/util/test/bytes.spec.ts packages/util/src/signature.ts packages/util/test/address.spec.ts packages/util/test/types.spec.ts packages/util/src/binaryTree.ts packages/util/src/verkle.ts
Standardize EVM error handling.	Introduce static errorMessages property on EVMError. Update opcode handlers and precompiles to access errors via EVMError.errorMessages. Rename EvmErrorResult function to EVMErrorResult. Refine error type checking in interpreter. Remove deprecated EOF error messages and SimpleErrors constant. Update BLS precompile error handling for 'ZERO' point.	packages/evm/src/opcodes/functions.ts packages/evm/src/errors.ts packages/evm/src/interpreter.ts packages/evm/src/evm.ts packages/evm/src/stack.ts packages/evm/src/precompiles/10-bls12-map-fp-to-g1.ts packages/evm/src/precompiles/0c-bls12-g1msm.ts packages/evm/src/precompiles/0f-bls12-pairing.ts packages/evm/src/precompiles/0b-bls12-g1add.ts packages/evm/src/precompiles/0d-bls12-g2add.ts packages/evm/src/precompiles/11-bls12-map-fp2-to-g2.ts packages/evm/src/precompiles/bls12_381/mcl.ts packages/evm/src/precompiles/bls12_381/noble.ts packages/evm/src/precompiles/0a-kzg-point-evaluation.ts packages/evm/src/precompiles/08-bn254-pairing.ts packages/evm/src/precompiles/09-blake2f.ts packages/evm/src/precompiles/06-bn254-add.ts packages/evm/src/precompiles/07-bn254-mul.ts packages/evm/src/opcodes/EIP2200.ts packages/evm/src/opcodes/util.ts packages/evm/test/runCall.spec.ts packages/vm/test/api/istanbul/eip-1344.spec.ts packages/vm/test/api/istanbul/eip-1884.spec.ts
Update test data and examples.	Update runGoerliBlock example to use testdata package. Move blockchain mock data to a TypeScript file. Update test data usage in various test files. Add new testdata files for RLP-encoded blocks. Update examples to use hexToBytes and other new utility functions. Add CLRequests example in @ethereumjs/block examples.	packages/vm/examples/runGoerliBlock.ts packages/vm/examples/run-blockchain.ts packages/client/test/sync/fetcher/accountfetcher.spec.ts packages/vm/examples/helpers/blockchain-mock-data.ts packages/block/examples/clrequests.ts packages/testdata/src/blocks/preLondonTestDataBlocks2RLP.ts packages/testdata/src/blocks/preLondonTestDataBlocks1RLP.ts packages/testdata/src/blocks/index.ts packages/block/test/block.spec.ts packages/vm/test/api/runBlock.spec.ts packages/blockchain/test/index.spec.ts packages/testdata/src/gethGenesis/withdrawalsGethGenesis.ts packages/tx/examples/custom-chain-id-tx.ts packages/blockchain/README.md packages/vm/examples/vmWithGenesisState.ts packages/vm/test/tester/runners/BlockchainTestsRunner.ts packages/common/examples/fromGeth.ts packages/common/test/hardforks.spec.ts packages/common/examples/customChain.ts packages/testdata/src/gethGenesis/invalidSpuriousDragonGethGenesis.ts packages/vm/examples/vmWith4844.ts packages/vm/examples/eips.ts packages/vm/examples/vmWithEIPs.ts packages/vm/examples/run-solidity-contract.ts
Update CI workflows and configuration files.	Update docker image tag in workflow. Add .nvmrc file. Add Jekyll GitHub Pages workflow.	.github/workflows/docker-image.yml .nvmrc .github/workflows/jekyll-gh-pages.yml
Update dependencies.	Update @noble/curves dependency.	packages/evm/package.json package-lock.json
Add support for EIP-7685 Consensus Layer Requests.	Add constants for deposit log parsing in vm/requests.ts. Update parseDepositLog function with improved validation. Add CLRequests test file in block/test. Update documentation in util, block, and vm READMEs.	packages/block/src/block/constructors.ts packages/vm/src/requests.ts packages/block/test/clrequests.spec.ts packages/util/src/request.ts packages/util/README.md packages/block/README.md packages/vm/README.md
Refine State Manager implementations.	Rename verifyPostState to verifyVerklePostState in Verkle state managers. Improve type hints and handling of genesis state data. Update storage value handling in StatelessVerkleStateManager.	packages/statemanager/src/statefulVerkleStateManager.ts packages/statemanager/src/statelessVerkleStateManager.ts packages/statemanager/src/statefulBinaryTreeStateManager.ts
Minor fixes and code cleanups.	Update accountfetcher logic to handle undefined partialResult and highestKnownHash. Update trienodefetcher to use bytesToHex for key conversion. Fix skeleton init test. Add undefined check for peer.id in peerpool. Improve type hints in snapsync test. Update runCode test error check. Remove unnecessary toBytes call in mpt encoding. Simplify partialResult type in storagefetcher test. Correct assertion in vm events test.	packages/client/src/sync/fetcher/accountfetcher.ts packages/client/src/sync/fetcher/trienodefetcher.ts packages/client/test/sync/skeleton.spec.ts packages/client/src/net/peerpool.ts packages/client/test/sim/snapsync.spec.ts packages/evm/test/runCode.spec.ts packages/mpt/src/util/encoding.ts packages/client/test/sync/fetcher/storagefetcher.spec.ts packages/vm/test/api/events.spec.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[sourcery-ai]

Hey @Dargon789 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The PR title "Vitest browser cleanup" seems inconsistent with the broad scope of changes, which include major refactoring, dependency updates, and documentation overhauls across many packages.

Here's what I looked at during the review

• 🟡 General issues: 6 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ethereumjs-monorepo-zmjp	❌ Failed (Inspect)			Apr 25, 2025 11:12pm
vite	❌ Failed (Inspect)			Apr 25, 2025 11:12pm