Skip to content

monorepo: clean up more test data#4001

Merged
gabrocheleau merged 3 commits into
masterfrom
vm/clean-up-testdata
Apr 20, 2025
Merged

monorepo: clean up more test data#4001
gabrocheleau merged 3 commits into
masterfrom
vm/clean-up-testdata

Conversation

@gabrocheleau

Copy link
Copy Markdown
Contributor

This PR cleans up some more test data

@codecov

codecov Bot commented Apr 19, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (34b271e) to head (8794e43).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.34% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.96% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.09% <ø> (ø)
mpt 89.76% <ø> (+0.35%) ⬆️
statemanager 69.16% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.53% <ø> (ø)
vm 55.19% <0.00%> (-2.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

acolytec3
acolytec3 previously approved these changes Apr 19, 2025

@acolytec3 acolytec3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochem-brouwer jochem-brouwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two micro nits 😄 👍

CI also fails, maybe it is due to this undefined blockchain mock data?

Comment thread packages/vm/examples/helpers/blockchain-mock-data.ts Outdated
Comment thread packages/vm/examples/run-blockchain.ts

@jochem-brouwer jochem-brouwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 👍

@gabrocheleau gabrocheleau merged commit f5e4537 into master Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants