Skip to content

monorepo: revert noble refactoring#4037

Merged
gabrocheleau merged 3 commits into
masterfrom
monorepo/revert-noble-refactoring
Apr 26, 2025
Merged

monorepo: revert noble refactoring#4037
gabrocheleau merged 3 commits into
masterfrom
monorepo/revert-noble-refactoring

Conversation

@gabrocheleau

Copy link
Copy Markdown
Contributor

This PR reverts the noble refactoring done in #4030 which increased bundle size but keeps the ethereum-cryptography upgrade.

@gabrocheleau gabrocheleau added PR state: merge ready package: monorepo dependencies Pull requests that update a dependency file labels Apr 26, 2025
@codecov

codecov Bot commented Apr 26, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.86777% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (17852b5) to head (c4a3272).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <100.00%> (ø)
blockchain 89.32% <ø> (ø)
client 67.99% <100.00%> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <100.00%> (+0.07%) ⬆️
evm 73.11% <75.00%> (ø)
mpt 89.69% <100.00%> (-0.06%) ⬇️
statemanager 69.06% <93.33%> (ø)
static 99.11% <90.90%> (ø)
tx 89.89% <100.00%> (ø)
util 89.19% <100.00%> (ø)
vm 55.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holgerd77 holgerd77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@gabrocheleau gabrocheleau merged commit 060f690 into master Apr 26, 2025
@holgerd77 holgerd77 deleted the monorepo/revert-noble-refactoring branch April 28, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file package: monorepo PR state: merge ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants