Display return versions in view licence setup tab #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add a Returns for requirements table and buttons to the view licence set up page. This will be initially feature toggled false. This change is part of the charge information page replacement seen in this previous work - #1034
…returns-requirements # Conflicts: # app/presenters/licences/set-up.presenter.js # app/services/licences/view-licence-set-up.service.js # app/views/licences/tabs/set-up.njk
rename to returnVersions
Cruikshanks
changed the title
Cruikshanks
requested changes
Jun 12, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
requested changes
Jun 12, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
requested changes
Jun 12, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
…uirements' into feature-view-licence-returns-requirements
Cruikshanks
requested changes
Jun 13, 2024
jonathangoulding
added a commit
that referenced
this pull request
Jun 18, 2024
https://eaflood.atlassian.net/browse/WATER-4422 The requirements for return journey has been built and the check page has been finished. This showed a page with requirements for returns allowing users to make changes to requirements for returns. This piece of work will replicate the requirements for returns check page but will not allow users to make changes (the card and information is identical, apart from the title and a return reference). There will be a link "View" on the licence set up page that links to this page. That is added as part of this change. Work for this was done here - #1054
jonathangoulding
added a commit
that referenced
this pull request
Jun 18, 2024
https://eaflood.atlassian.net/browse/WATER-4422 The requirements for return journey has been built and the check page has been finished. This showed a page with requirements for returns allowing users to make changes to requirements for returns. This piece of work will replicate the requirements for returns check page but will not allow users to make changes (the card and information is identical, apart from the title and a return reference). There will be a link "View" on the licence set up page that links to this page. That is added as part of this change. Work for this was done here - #1054
jonathangoulding
added a commit
that referenced
this pull request
Jun 21, 2024
* Add requirements for returns view page https://eaflood.atlassian.net/browse/WATER-4422 The requirements for return journey has been built and the check page has been finished. This showed a page with requirements for returns allowing users to make changes to requirements for returns. This piece of work will replicate the requirements for returns check page but will not allow users to make changes (the card and information is identical, apart from the title and a return reference). There will be a link "View" on the licence set up page that links to this page. That is added as part of this change. Work for this was done here - #1054
Cruikshanks
added a commit
that referenced
this pull request
Aug 30, 2024
https://eaflood.atlassian.net/browse/WATER-4407 > Part of the work to replace NALD for handling return requirements When we [started displaying return versions](#1054) in the view licence set up tab we should have excluded those with a 'draft' status. These have been imported from NALD, but found to have no return requirements which isn't valid in NALD. A decision will be made on what to do with them once we return requirements has gone live in WRLS. Till then, we just need to ensure they don't appear in this table.
Cruikshanks
added a commit
that referenced
this pull request
Aug 30, 2024
https://eaflood.atlassian.net/browse/WATER-4407 > Part of the work to replace NALD for handling return requirements When we [started displaying return versions](#1054) in the view licence set up tab, we should have excluded those with a 'draft' status. These have been imported from NALD but found to have no return requirements, which isn't valid in NALD. Once the return requirements have gone live in WRLS, a decision will be made on what to do with them. Until then, we need to ensure they don't appear in this table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4407
This adds the Requirements for returns table (return versions) to the 'Licence set up' tab on our new view licence page.
It also adds the buttons to create new ones, though these are placed behind a feature flag as we are not yet ready for the switchover.
This builds on the work done in View Licence set up page.