-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View Licence set up page #1034
Merged
jonathangoulding
merged 37 commits into
main
from
feature-view-licence-charge-information-tab
May 23, 2024
Merged
View Licence set up page #1034
jonathangoulding
merged 37 commits into
main
from
feature-view-licence-charge-information-tab
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page replace the existing charge information page. The page will show charge information for a licence and allow users to create a new charge version to manage licence billing. Only restricted users can use this page and only some of those users can create a new charge and make the licence non-chargeable.
jonathangoulding
added
the
housekeeping
Refactoring, tidying up or other work which supports the project
label
May 20, 2024
add links as an array to allow multiple action links
test fetch workflows
jonathangoulding
force-pushed
the
feature-view-licence-charge-information-tab
branch
from
May 21, 2024 10:36
9fd2f70
to
8bc07b6
Compare
jonathangoulding
force-pushed
the
feature-view-licence-charge-information-tab
branch
from
May 22, 2024 08:52
0c722a3
to
8d7ef05
Compare
jonathangoulding
requested review from
Cruikshanks and
robertparkinson
and removed request for
Cruikshanks
May 22, 2024 08:52
Co-authored-by: Alan Cruikshanks <[email protected]>
jonathangoulding
force-pushed
the
feature-view-licence-charge-information-tab
branch
from
May 22, 2024 12:49
4fcc843
to
74b1ce3
Compare
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final NITS!
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
approved these changes
May 23, 2024
jonathangoulding
added a commit
that referenced
this pull request
May 23, 2024
This will add an agreement table and buttons to the view licence set up page. The agreements action are based on the user role and state of an agreement. An authorised user can delete/end/recalculate an agreement as well as set up a new agreement This change is part of the charge information page replacement seen in this previous work - #1034
jonathangoulding
added a commit
that referenced
this pull request
May 28, 2024
This will add a Returns for requirements table and buttons to the view licence set up page. This will be initially feature toggled false. This change is part of the charge information page replacement seen in this previous work - #1034
jonathangoulding
added a commit
that referenced
this pull request
May 30, 2024
* View licence set up agreements This will add an agreement table and buttons to the view licence set up page. The agreements action are based on the user role and state of an agreement. An authorised user can delete/end/recalculate an agreement as well as set up a new agreement This change is part of the charge information page replacement seen in this previous work - #1034 --------- Co-authored-by: Robert Parkinson <[email protected]>
jonathangoulding
added a commit
that referenced
this pull request
Jun 13, 2024
* View licence set up returns for requirements This will add a Returns for requirements table and buttons to the view licence set up page. This will be initially feature toggled false. This change is part of the charge information page replacement seen in this previous work - #1034 --------- Co-authored-by: Alan Cruikshanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page replaces the existing charge information page.
The page will show charge information for a licence and allow users to create a new charge version to manage licence billing.
Only restricted users can use this page and only some of those users can create a new charge and make the licence non-chargeable.