Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Licence set up page #1034

Merged
merged 37 commits into from
May 23, 2024

Conversation

jonathangoulding
Copy link
Collaborator

@jonathangoulding jonathangoulding commented May 20, 2024

This page replaces the existing charge information page.

The page will show charge information for a licence and allow users to create a new charge version to manage licence billing.

Only restricted users can use this page and only some of those users can create a new charge and make the licence non-chargeable.

This page replace the existing charge information page.

The page will show charge information for a licence and allow users to create a new charge version to manage licence billing.

Only restricted users can use this page and only some of those users can create a new charge and make the licence non-chargeable.
@jonathangoulding jonathangoulding added the housekeeping Refactoring, tidying up or other work which supports the project label May 20, 2024
@jonathangoulding jonathangoulding self-assigned this May 20, 2024
@jonathangoulding jonathangoulding force-pushed the feature-view-licence-charge-information-tab branch from 9fd2f70 to 8bc07b6 Compare May 21, 2024 10:36
@jonathangoulding jonathangoulding force-pushed the feature-view-licence-charge-information-tab branch from 0c722a3 to 8d7ef05 Compare May 22, 2024 08:52
@jonathangoulding jonathangoulding marked this pull request as ready for review May 22, 2024 08:52
@jonathangoulding jonathangoulding requested review from Cruikshanks and robertparkinson and removed request for Cruikshanks May 22, 2024 08:52
@jonathangoulding jonathangoulding marked this pull request as draft May 22, 2024 09:01
@jonathangoulding jonathangoulding marked this pull request as ready for review May 22, 2024 09:08
Co-authored-by: Alan Cruikshanks <[email protected]>
@jonathangoulding jonathangoulding force-pushed the feature-view-licence-charge-information-tab branch from 4fcc843 to 74b1ce3 Compare May 22, 2024 12:49
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final NITS!

app/presenters/licences/set-up.presenter.js Outdated Show resolved Hide resolved
app/presenters/licences/set-up.presenter.js Outdated Show resolved Hide resolved
app/presenters/licences/set-up.presenter.js Outdated Show resolved Hide resolved
app/presenters/licences/set-up.presenter.js Outdated Show resolved Hide resolved
app/presenters/licences/set-up.presenter.js Outdated Show resolved Hide resolved
app/services/licences/fetch-workflows.service.js Outdated Show resolved Hide resolved
test/services/licences/view-licence-set-up.service.test.js Outdated Show resolved Hide resolved
test/services/licences/view-licence-set-up.service.test.js Outdated Show resolved Hide resolved
@jonathangoulding jonathangoulding merged commit a8dfbe2 into main May 23, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the feature-view-licence-charge-information-tab branch May 23, 2024 12:17
jonathangoulding added a commit that referenced this pull request May 23, 2024
This will add an agreement table and buttons to the view licence set up page.

The agreements action are based on the user role and state of an agreement.

An authorised user can delete/end/recalculate an agreement as well as set up a new agreement

This change is part of the charge information page replacement seen in this previous work - #1034
jonathangoulding added a commit that referenced this pull request May 28, 2024
This will add a Returns for requirements table and buttons to the view licence set up page.

This will be initially feature toggled false.

This change is part of the charge information page replacement seen in this previous work - #1034
jonathangoulding added a commit that referenced this pull request May 30, 2024
* View licence set up agreements

This will add an agreement table and buttons to the view licence set up page.

The agreements action are based on the user role and state of an agreement.

An authorised user can delete/end/recalculate an agreement as well as set up a new agreement

This change is part of the charge information page replacement seen in this previous work - #1034

---------

Co-authored-by: Robert Parkinson <[email protected]>
jonathangoulding added a commit that referenced this pull request Jun 13, 2024
* View licence set up returns for requirements

This will add a Returns for requirements table and buttons to the view licence set up page.

This will be initially feature toggled false.

This change is part of the charge information page replacement seen in this previous work - #1034

---------

Co-authored-by: Alan Cruikshanks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants