Do not display draft return versions in set up #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4407 > Part of the work to replace NALD for handling return requirements When we [started displaying return versions](#1054) in the view licence set up tab we should have excluded those with a 'draft' status. These have been imported from NALD, but found to have no return requirements which isn't valid in NALD. A decision will be made on what to do with them once we return requirements has gone live in WRLS. Till then, we just need to ensure they don't appear in this table.
Cruikshanks
added
the
housekeeping
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
jonathangoulding
approved these changes
Aug 30, 2024
robertparkinson
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4407
When we started displaying return versions in the view licence set up tab, we should have excluded those with a 'draft' status.
These have been imported from NALD but found to have no return requirements, which isn't valid in NALD.
Once the return requirements have gone live in WRLS, a decision will be made on what to do with them. Until then, we need to ensure they don't appear in this table.