Skip to content

feat(audit): persist append-only checkpoint acceptance trail - #94

Closed
seonghobae wants to merge 2 commits into
agent/checkpoint-opentelemetry-observability-v3from
agent/checkpoint-audit-trail-v3
Closed

feat(audit): persist append-only checkpoint acceptance trail#94
seonghobae wants to merge 2 commits into
agent/checkpoint-opentelemetry-observability-v3from
agent/checkpoint-audit-trail-v3

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Current stack purpose

This Draft carries the append-only checkpoint acceptance-audit slice after durable checkpoint storage and checkpoint observability. The audit behavior remains staged only; it is not protected-main behavior.

Repaired stack boundary — 2026-08-13

Fresh refs immediately before the repair were:

The prior #94 head had diverged: its audit commit was one commit ahead of the historical merge base but seven predecessor commits behind the current #92 head. The predecessor advancement added exact-source CI governance on .github/workflows/ci.yml, tests/test_workflow_contracts.py, docs/doctoring/exact-source-ci-evidence.md, and CHANGELOG.md, while the audit slice also changed the CI workflow and changelog.

The branch was repaired non-destructively. Current exact #94 head is 22f9c6111d7f03a60cd5a6da845c9e16b5e60356, a two-parent merge commit whose first parent is the prior #94 audit head and whose second parent is exact current #92 head. GitHub comparison from #92 now reports ahead by 2, behind by 0, merge base exactly #92 head. No force-push, destructive rebase, conflict-side history selection, protected-main write, or predecessor evidence transfer was used.

Integration RED -> fix

A read-only synthetic merge exposed one deterministic integration defect before the branch move: the newly added checkpoint-audit-integration job still used an ordinary checkout, while #92's current tests/test_workflow_contracts.py requires every CI checkout to bind ref: ${{ github.event.pull_request.head.sha || github.sha }} and immediately verify the checked-out source SHA.

The real merge tree therefore preserves both predecessor and audit results while adding that same exact-source checkout and verification contract to the audit integration job. Fresh exact-head inspection confirms all four CI checkout sites now carry persist-credentials: false, the exact contributor-head ref, and an immediate Verify exact source head step. The audit job remains Python 3.14 PostgreSQL integration with the existing pinned PostgreSQL image and live audit test command.

Current exact evidence

  • Base: feat(observability): instrument durable checkpoint operations #92 exact head b9fa4f35772ae3259885cfbdaa3a6701964fe1ab.
  • Head: 22f9c6111d7f03a60cd5a6da845c9e16b5e60356.
  • Ancestry: ahead 2 / behind 0; merge base equals the exact live predecessor.
  • GitHub state: Draft and mergeable.
  • Formal reviews: none at the latest fresh inspection.
  • Unresolved inline review threads: zero at the latest fresh inspection.
  • Fresh repository CI and Release Acceptance for this exact repaired head are queued. Queued evidence is not acceptance, and no historical or synthetic check is reused.

Feature scope retained from the audit slice

The intended audit delta remains: tenant-isolated accepted-save evidence, append-only PostgreSQL audit storage, same-transaction persistence, least-privilege audit-role hardening, clock_timestamp() semantics, package/container migration identity, bounded reads, public API, tests, ADR/operator/doctoring guidance, and release/CI contracts. These claims are ACTIVE-PR scope only until integrated through protected governance.

Dependency and merge boundary

Current dependency order remains #60 -> #92 -> #94 -> #95 -> #96 -> #97, subject to fresh protected-main reconciliation of earlier prerequisites. #95 is now stale against this repaired #94 head and must be reconciled only after this boundary's exact result is validated; later stack evidence does not transfer backward.

Keep Draft until every then-current repository/organization CI, security, dependency, coverage, package, provenance, live PostgreSQL, automated-review, and Release Acceptance gate is terminal-success on one unchanged exact head and every live policy requirement is satisfied. Queued, pending, cancelled, skipped-required, absent, neutral-required, stale-head/base, predecessor, status-only, synthetic-only, author-only, rate-limited, infrastructure-only, or failed evidence is not acceptance.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba02aab4-52f9-4da8-9163-6e7f78f061e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review exact current replacement head cc7c862cff76521ead8696c7d6bfe1a2c4b31780 against exact #92 predecessor 2235ec3eec2f73cb7ea3117c7b881d3bd1f0bdb7. Validate append-only checkpoint acceptance audit semantics, least-privilege PostgreSQL/RLS behavior, migration identity, bounded reads, and evidence confidentiality. Do not transfer review/check evidence from superseded #79.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

@seonghobae I will review pull request #94 against the specified exact predecessor and head. I will validate the requested audit, PostgreSQL/RLS, migration, read-bound, and confidentiality properties. I will not treat superseded #79 review or check evidence as acceptance evidence.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant