fix(postgres): default optional logging to content-safe evidence - #119
Conversation
|
Warning Review limit reached
Next review available in: 1 minute You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head50fd8f8a0387c1db77974ab0de8a3abee43cff4e. -
Head SHA:
50fd8f8a0387c1db77974ab0de8a3abee43cff4e -
Workflow run: 31545670998
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: postgresql.conf.custom"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: postgresql.conf.custom"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: postgresql-logging-privacy.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: postgresql-logging-privacy.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test: test_postgres_logging_privacy_contract.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_postgres_logging_privacy_contract.py"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: postgresql.conf.custom"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: postgresql.conf.custom"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: postgresql-logging-privacy.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: postgresql-logging-privacy.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test: test_postgres_logging_privacy_contract.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_postgres_logging_privacy_contract.py"]
R3 --> V3["targeted test run"]
|
1 participant
Scope
Privacy- and resource-safe defaults for the optional PostgreSQL monitoring profile. This PR keeps SQL/bind logging, query-statistics collection/preload, connection events, temporary-file events, I/O/WAL timing, function statistics, and commit timestamps opt-in or conservatively bounded, while preserving authorized business-data access. Detailed rationale, rollback, residual
pg_stat_activity/CSV metadata boundaries, and PostgreSQL primary references are maintained indocs/doctoring/postgresql-logging-privacy.md.Test-first evidence
The branch contains the earlier RED→GREEN cycles documented in its commit history, including the focused
pg_stat_statementspreload/shared-memory regression. Predecessor workflow results remain development provenance only.Current exact state
4ad8f74f1ab2a68e4554802a368abda2b6cd9704.main:06f88be7f7c3a3ce5e756bc3bf03f298031a0286.4759169a1f0956babac63efc8d5de10c6f87cb9a; the three PR-owned paths were disjoint from all protected-main changes since the prior base.31542858782, SAST Semgrep31542858842, and Security Scan31542858879are queued. Queued evidence is not acceptance.required_approving_review_count: 0, code-owner review disabled, and no last-push approval requirement.Repository exact-source governance #88 is now on protected
main, so the previous draft prerequisite is satisfied. Do not reuse pre-#88 synthetic-merge workflow evidence. Merge only if this unchanged source head receives terminal success for every live required repository/central workflow, remains mergeable against the then-live protected base, and has zero valid unresolved findings.Integration boundary
This branch owns only
docker/postgres/postgresql.conf.custom,docs/doctoring/postgresql-logging-privacy.md, andtests/test_postgres_logging_privacy_contract.py. It does not change provider transport, schemas, checkpoint behavior, Compose, release authority, or the stagedpg_cronretirement owned elsewhere. Issue #120 remains the separate container-native logging/storage-lifecycle follow-up.