feat(checkpoint): persist resumable result progress - #60
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head CI finding on 45761886664d5a1a9ef934ebcd326beea5d1e6f3 (CI run 31116219720): Python 3.10/3.12/3.14 and the coverage job fail only on two deterministic documentation-contract assertions, with 578 tests passing and 5 deselected.
Both required semantic phrases are present but split by Markdown line wrapping: fail-closed\n rollback in CHANGELOG.md, and Row\nsecurity policies in the APA reference. This is assertion brittleness rather than a missing authoritative contract. Fix on the existing branch path by normalizing document whitespace in the documentation-test helper before phrase matching (for example, joining text.split() with one space), while retaining the exact required phrases and all authoritative source details. Do not reflow prose solely to satisfy raw substring layout, weaken any required phrase, or count the currently in-progress Release Acceptance run as success. Rerun every exact-head CI and release-acceptance gate after the fix.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head deployment finding and test-first remediation on 90854868c7099b93087ceea07982675174112f24 over stacked base cc1595774ee6ab076f72dc6ba5a4175d3bec0f5d: the package and container checkpoint SQL files were byte-identical, but docker/postgres/Dockerfile did not copy the checkpoint migration into /docker-entrypoint-initdb.d, so a fresh bundled PostgreSQL image would never execute the new durable checkpoint schema. Test-only RED commit a223f7277c71f504cdeb9a65a9696d0c1dd1156e requires both byte identity and a unique ordered image-init destination. GREEN commit 90854868c7099b93087ceea07982675174112f24 installs init/03_result_stream_checkpoints.sql as /docker-entrypoint-initdb.d/04_result_stream_checkpoints.sql, after the existing cron script, without overwriting another init entry. No workflow or parallel branch writer was added. Previous ff183... queued CI/Release Acceptance evidence is stale; no current-head workflow run is counted as success until it exists and completes. This author review is audit evidence only, not independent approval.
|
Current head/base revalidation after the deployment-assurance doc/test slice:
This head now has a permanent documentation contract tying the byte-identical checkpoint migration to No stale predecessor run, queued/pending result, synthetic merge evidence, automated status, or absent protection/security surface is being counted as merge authority. In particular, the successful CI run above is not being promoted to exact-source evidence without an in-job source-SHA assertion. The PR remains a stacked draft; fresh exact-source CI after integration, independent non-author approval, and repository protection/security gates remain mandatory. |
cc15957 to
76b4abe
Compare
efe2c81 to
6b2e19e
Compare
|
@coderabbitai review Review-only request for exact current source head |
|
|
|
@coderabbitai review |
|
|
Ancestry is now obsolete: immediate predecessor PR #59 was freshly verified and closed as superseded by current-main replacement #177. This PR still targets the retained historical |
Parked historical stack — design/test provenance only
This Draft contains the former durable PostgreSQL result-checkpoint store slice: tenant-qualified checkpoint identity, exact compare-and-swap advancement, transaction-coupled save/load operations, forced RLS requirements, byte-identical package/container migrations, fail-closed rollback for non-empty acknowledgement evidence, explicit nonblank DSN selection, bounded PostgreSQL counters, and deterministic migration/concurrency/integration coverage.
Fresh exact topology
agent/persistent-result-checkpoint-store:a496bfcc4557904cefd6dc3c5f7f619b5ae5fda4;agent/resumable-stream-checkpoints:683a3e7f52e5529817180a6ace0c2b2176d85412;main:0052c00f31b404ef8b328f3175e3fe1245afc7c2, which now includes the current-main resumable streaming implementation from feat(streaming): rebuild resumable checkpoints on current main #177;feat/durable-checkpoint-store-current-mainwas created from that exact protected head and now carries fail-first RED commita2fb87b0354b459204005f54489aa786ec35b5da;No checks, reviews, approvals, ancestry, generated merge evidence, or staged acceptance from this historical PR transfer to the successor branch. This Draft must not be retargeted directly onto
mainand must not be merged.Reconstruction boundary
Continue only on the explicit current-main successor branch once the PR-creation control-plane lane is available. Preserve standalone/custom-store operation, trusted tenant/consumer authority, exact CAS semantics, caller-owned transaction coupling, forced RLS, descriptive two-or-more-word snake_case database objects, rollback protection, explicit DSN target authority, package/container migration identity, bounded PostgreSQL counters, and the explicit absence of a distributed exactly-once claim.
The reconstructed successor becomes merge-eligible only after one unchanged exact head satisfies live-base ancestry/mergeability, zero valid unresolved findings, exact 100% owned production statement/branch and public-docstring coverage, Python 3.10/3.12/3.14, realistic PostgreSQL migration/rollback/concurrency evidence, package/container/security/SAST/SBOM/provenance, every live required central workflow, Release Acceptance, and every approval requirement actually imposed by the live ruleset.