Skip to content

feat(checkpoint): rebuild durable result store on protected main - #181

Merged
seonghobae merged 24 commits into
mainfrom
feat/durable-checkpoint-store-current-main
Aug 14, 2026
Merged

feat(checkpoint): rebuild durable result store on protected main#181
seonghobae merged 24 commits into
mainfrom
feat/durable-checkpoint-store-current-main

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Durable PostgreSQL checkpoint store — current protected topology

This PR reconstructs the durable result-checkpoint store on the current protected baseline without transferring historical #60 checks, reviews, approvals, or generated-merge evidence.

Exact current identities

  • protected main: 6f367d97e5f5011bddb9c718f71a9a14e008f025;
  • exact contributor head: d21a29926081a7bfdd495da0a61c378de00bb04c;
  • exact merge base: protected main;
  • comparison: 24 commits ahead / 0 behind;
  • GitHub reports Ready, non-Draft, and mergeable;
  • changed surface: 16 files, limited to the checkpoint store, migration/container mirror, bounded ADR/doctoring, package export, and focused unit/live acceptance tests;
  • unresolved inline review threads: zero at the latest exact-head inspection.

No protected-main source/documentation mutation, force-push, destructive rebase, conflict-side selection, or gate weakening occurred.

Test-first evidence

The durable public API, deployable-image installation path, validation confidentiality, live tenant/RLS behavior, rollback safety, concurrent first-writer behavior, CAS advancement, stale-writer refusal, and caller-owned transaction coupling were all developed through observable RED states followed by narrow GREEN changes.

Notable preserved evidence includes:

  • test-only ff5d7c2241ce28ec860abe74f6ccf5d0f44720a0: public durable-store symbols absent;
  • d6c213ff25963f6988e7e3d4db47d8c01db9f3b4: narrow public export implementation;
  • test-only 32329f0c8e97e2a707c813ca0d598be77d423f94: deployable PostgreSQL image omitted migration 0007;
  • 91f0139e4967ec6ca67fa8779a1c887e5f6ed001: installs the existing checkpoint migration into /docker-entrypoint-initdb.d;
  • f009f942c71398315083957b240db475a4beda5c: auditable cleanup restoring the pre-existing ARG PG_MAJOR=16 default after the preceding implementation accidentally removed it;
  • subsequent live PostgreSQL/container acceptance proves tenant-qualified RLS/FORCE RLS, isolation, atomic safe rollback, concurrent convergence/conflict behavior, CAS semantics, and transaction rollback/commit coupling.

The store provides durable tenant-qualified checkpoint CAS and optional same-PostgreSQL-transaction coupling. It deliberately does not claim distributed exactly-once delivery.

Exact-head validation

For unchanged head d21a29926081a7bfdd495da0a61c378de00bb04c against base 6f367d97e5f5011bddb9c718f71a9a14e008f025:

  • repository CI: terminal success, including Python 3.10, 3.12, and 3.14;
  • repository coverage configuration has branch = true and fail_under = 100, and the exact-head quality job is terminal success;
  • public-docstring, lint, package, container/PostgreSQL runtime smoke, and reproducibility acceptance are terminal success;
  • Security Scan, SAST Semgrep, CodeQL, OSV, and Trivy evidence on this head are terminal success;
  • all live ruleset-required organization workflows are terminal success, including Required OpenCode Review, Required Noema Review, Strix Security Scan, Security Scan, SAST, Close Empty PR, and PR Review / Merge Scheduler;
  • Release Acceptance reran after promotion from Draft and completed successfully on the unchanged exact head;
  • formal review approvals required by the live ruleset: 0;
  • unresolved review threads: 0.

One conditional Strix child check (publish-manual-pr-evidence-status) is skipped; it is not treated as success and is not a live required workflow/gate. The required Strix workflow itself completed successfully.

CodeRabbit attempted a current-head review after the PR became Ready but reported its organization/developer review limit exhausted. That rate-limited attempt is not counted as approval or exact-head success. There are no CodeRabbit current-head findings to resolve, and CodeRabbit is not a live required ruleset workflow.

Documentation and promotion boundary

This PR carries its bounded ADR (0007) and doctoring evidence. Broad README/architecture/CHANGELOG/canonical-document reconstruction is owned by active Draft #93 and must not be raced from this source branch. The current protected-main README/architecture do not claim this checkpoint store is already implemented; after merge, #93 must describe the protected-main state accurately before its own promotion.

Merge only while this exact contributor head and exact live base remain unchanged, all required workflows remain terminal-success, mergeability remains true, and no new valid review/security finding appears.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 87 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0169e5b7-a339-41b9-a420-ec7e93a20a7b

📥 Commits

Reviewing files that changed from the base of the PR and between 6f367d9 and d21a299.

📒 Files selected for processing (16)
  • docker/postgres/Dockerfile
  • docker/postgres/init/03_result_stream_checkpoints.sql
  • docs/adr/0007-durable-result-checkpoint-store.md
  • docs/doctoring/durable-result-checkpoint-store.md
  • pg_llm_batch/__init__.py
  • pg_llm_batch/checkpoint_store.py
  • pg_llm_batch/migrations/0007_result_stream_checkpoints.sql
  • pg_llm_batch/migrations/rollback/0007_result_stream_checkpoints.sql
  • tests/smoke_checkpoint_postgres_acceptance.sh
  • tests/smoke_checkpoint_store_concurrency.py
  • tests/smoke_postgres_container_logging.sh
  • tests/test_checkpoint_store.py
  • tests/test_checkpoint_store_public_api.py
  • tests/test_checkpoint_store_schema.py
  • tests/test_checkpoint_store_validation_confidentiality.py
  • tests/test_durable_checkpoint_store_current_main.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant