test(errors): rebuild ValidationError confidentiality on current main - #185
Closed
seonghobae wants to merge 2 commits into
Closed
test(errors): rebuild ValidationError confidentiality on current main#185seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSED UNMERGED — current-main feasibility experiment for Issue #132
This branch started from protected
main9640ab9765db427412f3d108a4fc9eadf4fa1d8cto re-establish the rejected-value confidentiality RED without transferring evidence from closed experiment #133. The RED remained valid: a unique credential-shaped rejected value must not escape through the safe-defaultValidationErrormessage, args, repr, or structured evidence.The branch then tested the narrow hypothesis that changing the generic constructor default could be made GREEN in isolation. Exact current head
8f27a2eaf684ec0e0208db1044530112613ff26efalsifies that hypothesis on the current repository surface.Exact integration evidence
mainduring final triage:a70866e47b74eb74654aa0f8dd12f72260a5bbe2.8f27a2eaf684ec0e0208db1044530112613ff26e.pg_llm_batch/exceptions.pyandtests/test_validation_error_confidentiality_current_main.py; GitHub reports it mergeable as a Draft, but it is not gate-clean.31752607500is terminal-failure. Its coverage/package job checked out the exact contributor head, then reported 45 failed / 827 passed. The failures are deterministic compatibility failures, not infrastructure failures: numerous existing package contracts intentionally retain bounded non-sensitive rejected values such as numeric limits, byte sizes, endpoint/configuration selectors, tenant/lifecycle validation markers, and other operator-useful evidence.RCA and next safe implementation boundary
The privacy defect in Issue #132 remains valid, but a blanket constructor-default replacement is not an isolated two-file fix. This exact current-main experiment independently reproduces the integration boundary already exposed by #133: the eventual solution needs a call-site compatibility/classification pass that separates confidential/content-bearing rejected values from explicitly reviewed bounded non-sensitive diagnostics, then introduces the smallest explicit safe-value/disclosure policy without erasing useful operational evidence.
That audit should start only after currently active validation-producing owners settle. In particular, Draft #181 is adding durable checkpoint-store validation on a separate active branch, so broad exception/call-site churn here would race a moving validation surface. No code, checks, reviews, approvals, synthetic merge evidence, or conclusions from this closed branch transfer automatically to the future implementation.
Closing this PR unmerged preserves the RED/feasibility evidence while keeping Issue #132 open for the correctly scoped successor.