feat(state-checkpoint): persist durable procedural evaluation history - #597
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAgent Runtime에 인증된 procedural evaluation/rejection history를 State / Checkpoint에 저장하는 repository를 추가했습니다. Digest chain, monotonic CAS, exact replay, rejection projection, lineage, capacity, retained history integrity를 검증합니다. ChangesProcedural evaluation history
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant DurableProceduralEvaluationHistoryRepository
participant DurableObjectStorage
Caller->>DurableProceduralEvaluationHistoryRepository: 인증된 평가 append 요청
DurableProceduralEvaluationHistoryRepository->>DurableObjectStorage: 현재 history transaction 조회
DurableProceduralEvaluationHistoryRepository->>DurableProceduralEvaluationHistoryRepository: lineage와 digest chain 검증
DurableProceduralEvaluationHistoryRepository->>DurableObjectStorage: CAS append 저장
DurableProceduralEvaluationHistoryRepository-->>Caller: accepted 또는 exact replay 반환
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review c2ee6ba195182a1a8fb2da7d55656e66e45207c5: two valid repair findings.
- Application CI run
34482581525is a real source/test RED, not infrastructure noise. All 4,575 tests pass, but the repository-wide 100% coverage gate fails because the retained-history verifier'spreviously_rejectedarm atsrc/state-checkpoint/procedural-evaluation-history.ts:222-223is not exercised. Repair with a focused restart/read regression that proves a persistedpreviously_rejectedevent reconstructs successfully; do not weaken or exclude coverage. - This PR changes production State / Checkpoint behavior but currently changes only source and test files. Protected
CLAUDE.md/CONTRIBUTING.mdrequire every behavior change to updateCHANGELOG.mdunder## Unreleased. Add the minimal current entry while preserving Noema State / Checkpoint ownership, the existing Workflow / Task and Policy / Approval boundaries, bounded no-eviction history, andactivationAuthorized:false.
No self-approval. Re-review the causal successor exact after both repairs and require all four exact-head gates again.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head re-review 9e7237ed2fe92fca779aee2d7c30fce1f38b09b6: the two prior findings are causally repaired. The retained previously_rejected integrity branch now has a restart/read regression, the State / Checkpoint behavior is recorded under CHANGELOG.md ## Unreleased, and the unchanged exact has application CI, reviewer-ci, central Security Scan, and patch-validator-image terminal SUCCESS. No unresolved inline review threads are present. I found no remaining valid source/test/docs/DDD/authority finding in the current three-file delta. activationAuthorized:false and the Workflow / Task, Policy / Approval, Keyverse/provider/security/outbound ownership boundaries remain intact. COMMENT only; no self-approval.
Purpose
Implement the next Noema-owned #584 slice after protected #596: durable procedural evaluation/rejection history under the existing State / Checkpoint bounded context. This lane retains only payload-minimized exact graph/evaluation/authenticated signed-claim identities, uses monotonic CAS, preserves complete bounded history across restart, and makes the durable rejection set authoritative for later screening.
Reality RED → repair
Test-first exact
54ae12e6edc18a0ed6baa51c5fbd160631a89c37introduced the durable-history contract before production source. After the adapter and duplicate-handoff integrity repair landed, exactc2ee6ba195182a1a8fb2da7d55656e66e45207c5produced an observed application-CI RED in run34482581525: all 4,575 tests passed, but global coverage fell to 99.98% because retained-history verification did not execute thepreviously_rejectedintegrity arm atsrc/state-checkpoint/procedural-evaluation-history.ts:222-223.Causal successor
943d06defa6df274cb3b25d20861012725202f60adds a focused restart/read regression for a persistedpreviously_rejectedevent rather than weakening the 100% gate. Successor9e7237ed2fe92fca779aee2d7c30fce1f38b09b6also records the State / Checkpoint behavior change underCHANGELOG.md## Unreleased, as required by protected repository guidance. Hosted GREEN is claimed only from the final unchanged exact once observed.Boundary
No second Workflow / Task or execution-lifecycle truth. No graph promotion/publication or Policy / Approval authority.
activationAuthorized:falseremains invariant. No Keyverse key custody/discovery, provider routing, quarantine/security/outbound truth, cross-service SQL, or mutable sibling dependency. The adapter consumes only locally admitted Noema graph/authenticated-evaluation authority and persists digest/reference evidence.Draft until current exact has zero valid unresolved findings/threads and application CI, reviewer-ci, required central Security Scan, and patch-validator-image are terminal GREEN on the same head. Predecessor GREEN is not transferable.
Related: #584, #596.
Summary by CodeRabbit
새 기능
문서