Skip to content

docs(agent-runtime): align ADR-0017 with protected procedural authority - #600

Merged
seonghobae merged 2 commits into
mainfrom
docs/procedural-authority-protected-20260911
Sep 10, 2026
Merged

docs(agent-runtime): align ADR-0017 with protected procedural authority#600
seonghobae merged 2 commits into
mainfrom
docs/procedural-authority-protected-20260911

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

Protected #594/#597/#599 moved signed evaluator verification, durable evaluation/rejection history, and repository-verified State / Checkpoint read provenance into protected main, but ADR-0017 still contained pre-integration statements that described those slices as future work. This PR repairs moving-current architecture authority without changing ADR-0017 from Proposed or promoting source integration into Policy / Approval, release, publication, canary, deployment, or activation authority.

Reality RED → causal repair

Test-only exact 42322ff5d80eecf7ccb398fb7d3fca427ed06a84 extended test/procedural-protected-documentation-contract.test.ts so ADR-0017 must identify #597 durable history and #599 provenance-preserving verified reads, keep Policy / Approval CAS promotion/revocation separate, and reject three stale pre-integration phrases. Hosted application CI run 34501583173 checked out that exact head, passed typecheck, and failed at release tests; reviewer-ci, central Security Scan, and patch-validator-image succeeded on the same test-only exact. This is the intended repository-owned RED, not an infrastructure failure.

Causal exact 2dd2c34ef8abbcbdd1061a0a455fb49ba1014b40 updates only ADR-0017. It records protected #594 signed evaluator-handoff verification, #597 bounded durable evaluation/rejection history under the existing State / Checkpoint boundary, and #599 repository-verified read provenance. It also records #599's limitation: process-local provenance does not prove a previously admitted snapshot remains current after a later durable append. Policy / Approval CAS must remain separate and bind exact graph/evaluation/signed-claim/verified-history authority; graph publication, release, deployment, canary, activation, live signer trust, and external contract release remain distinct prerequisites.

On the unchanged causal exact, application CI 34505559928, reviewer-ci 34505559868, required central Security Scan 34505559873, and patch-validator-image 34505560094 are all terminal SUCCESS. Current-head two-file review found no additional valid repair finding or unresolved inline thread; the submitted review is COMMENT-only, not self-approval. Predecessor GREEN is not transferred.

Boundary

Documentation-only convergence. No source/runtime behavior, workflow, provider routing, credential/key custody, foreign-owner truth, quarantine/security, outbound authority, Policy / Approval decision, graph publication, or activation authority is added. ADR-0017 remains Proposed and activationAuthorized:false remains invariant.

Related: #584, #594, #597, #599.

Summary by CodeRabbit

  • 문서

    • ADR-0017에 오프라인 후보 스크리닝, 내구성 평가·거부 이력, 검증된 읽기 출처의 경계와 보호된 구성 요소가 반영되었습니다.
    • 스크리닝 결과만으로 활성화·거버넌스 증거·출시·게시 권한이 부여되지 않으며, 별도의 인증된 서명과 검증된 이력이 필요함을 명확히 했습니다.
  • 테스트

    • 관련 아키텍처 문서가 서명된 평가 및 상태·체크포인트 권한 기준과 일치하는지 검증하는 테스트가 추가되었습니다.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 95fa424c-b78d-4193-b938-ef29f9d82d39

📥 Commits

Reviewing files that changed from the base of the PR and between 69fce6c and 2dd2c34.

📒 Files selected for processing (2)
  • docs/adr/0017-procedural-graph-guidance.md
  • test/procedural-protected-documentation-contract.test.ts

📝 Walkthrough

Walkthrough

ADR-0017이 보호된 서명 평가, 내구성 평가·거부 이력, 검증된 읽기 출처, 승격·게시 조건을 반영하도록 갱신되었습니다. 새 문서 계약 테스트가 해당 내용과 제거된 이전 문구를 검증합니다.

Changes

보호된 문서 계약

Layer / File(s) Summary
ADR 보호 경계 및 구현 계획
docs/adr/0017-procedural-graph-guidance.md
서명 평가자 핸드오프 검증, State/Checkpoint 평가·거부 이력, 출처 보존 읽기, 승격·게시 조건과 잔여 제한 사항을 문서화합니다.
ADR 문서 계약 검증
test/procedural-protected-documentation-contract.test.ts
보호된 이력과 검증된 읽기 경계의 문구를 확인하고, 제거된 placeholder 문구의 재등장을 방지합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/procedural-authority-protected-20260911

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head review on 2dd2c34ef8abbcbdd1061a0a455fb49ba1014b40: the original executable documentation RED is repaired without widening authority. ADR-0017 now classifies protected #594 signed evaluator handoff, #597 bounded State / Checkpoint evaluation/rejection history, and #599 provenance-preserving repository read as protected source while explicitly retaining Proposed, activationAuthorized:false, and separate Policy / Approval CAS/publication/release/deployment authority. The #599 limitation that process-local read provenance does not prove currentness after a later append is preserved. Two-file diff review found no additional valid repair finding or unresolved thread. This is a COMMENT review, not self-approval.

@seonghobae
seonghobae marked this pull request as ready for review September 10, 2026 17:03
@seonghobae
seonghobae merged commit 0b5b4ec into main Sep 10, 2026
17 of 18 checks passed
@seonghobae
seonghobae deleted the docs/procedural-authority-protected-20260911 branch September 10, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant