docs(agent-runtime): align ADR-0017 with protected procedural authority - #600
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughADR-0017이 보호된 서명 평가, 내구성 평가·거부 이력, 검증된 읽기 출처, 승격·게시 조건을 반영하도록 갱신되었습니다. 새 문서 계약 테스트가 해당 내용과 제거된 이전 문구를 검증합니다. Changes보호된 문서 계약
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on 2dd2c34ef8abbcbdd1061a0a455fb49ba1014b40: the original executable documentation RED is repaired without widening authority. ADR-0017 now classifies protected #594 signed evaluator handoff, #597 bounded State / Checkpoint evaluation/rejection history, and #599 provenance-preserving repository read as protected source while explicitly retaining Proposed, activationAuthorized:false, and separate Policy / Approval CAS/publication/release/deployment authority. The #599 limitation that process-local read provenance does not prove currentness after a later append is preserved. Two-file diff review found no additional valid repair finding or unresolved thread. This is a COMMENT review, not self-approval.
Purpose
Protected #594/#597/#599 moved signed evaluator verification, durable evaluation/rejection history, and repository-verified State / Checkpoint read provenance into protected
main, but ADR-0017 still contained pre-integration statements that described those slices as future work. This PR repairs moving-current architecture authority without changing ADR-0017 from Proposed or promoting source integration into Policy / Approval, release, publication, canary, deployment, or activation authority.Reality RED → causal repair
Test-only exact
42322ff5d80eecf7ccb398fb7d3fca427ed06a84extendedtest/procedural-protected-documentation-contract.test.tsso ADR-0017 must identify #597 durable history and #599 provenance-preserving verified reads, keep Policy / Approval CAS promotion/revocation separate, and reject three stale pre-integration phrases. Hosted application CI run34501583173checked out that exact head, passed typecheck, and failed atrelease tests; reviewer-ci, central Security Scan, and patch-validator-image succeeded on the same test-only exact. This is the intended repository-owned RED, not an infrastructure failure.Causal exact
2dd2c34ef8abbcbdd1061a0a455fb49ba1014b40updates only ADR-0017. It records protected #594 signed evaluator-handoff verification, #597 bounded durable evaluation/rejection history under the existing State / Checkpoint boundary, and #599 repository-verified read provenance. It also records #599's limitation: process-local provenance does not prove a previously admitted snapshot remains current after a later durable append. Policy / Approval CAS must remain separate and bind exact graph/evaluation/signed-claim/verified-history authority; graph publication, release, deployment, canary, activation, live signer trust, and external contract release remain distinct prerequisites.On the unchanged causal exact, application CI
34505559928, reviewer-ci34505559868, required central Security Scan34505559873, and patch-validator-image34505560094are all terminal SUCCESS. Current-head two-file review found no additional valid repair finding or unresolved inline thread; the submitted review is COMMENT-only, not self-approval. Predecessor GREEN is not transferred.Boundary
Documentation-only convergence. No source/runtime behavior, workflow, provider routing, credential/key custody, foreign-owner truth, quarantine/security, outbound authority, Policy / Approval decision, graph publication, or activation authority is added. ADR-0017 remains Proposed and
activationAuthorized:falseremains invariant.Related: #584, #594, #597, #599.
Summary by CodeRabbit
문서
테스트