fix(toolchain): replace Wrangler/Miniflare GPL-family path - #540
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Regenerate package-lock.json with the exact pinned toolchain (Node.js 24.19.0 / npm 11.17.0) to remove the remaining Wrangler/Miniflare/Sharp/Libvips (LGPL-3.0) dependency path the PR description flagged as the last causal gap. Verified byte-identical to the lockfile-reproducibility workflow's own fresh-directory regeneration. Repair three test fixtures that had drifted from already-correct production changes on this branch, each confirmed against a Node 24.19.0/npm 11.17.0 run: - test/upload-artifact-node24-integrity.test.ts: add the new lockfile-reproducibility.yml workflow to the reviewed upload-artifact inventory (its two uses already pin the reviewed SHA). - test/patch-validator-image-contract.test.ts: match the current multi-line `npm pkg delete` block, which now also strips workerd and esbuild (added by this PR) from the validator image, plus the corresponding node_modules absence checks. - test/cloudflare-worker-config.test.mjs: move the "unsupported root key" fixture's new field ahead of the `[vars]` section header. TOML is section-scoped, so appending it after `[vars]` exercised the (intentionally open-ended) vars path instead of the root-key allowlist the test means to cover; the parser itself was already correct. Confirmed via `npm run typecheck` and the full `vitest` suite on the exact pinned toolchain. Remaining local failures (acquisition symlink/owner-mode checks, a SIGTERM-reaping timing test) reproduce only because this sandbox runs as root/uid 0, unlike the CI runner, and are not touched here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
Evidence: lockfile regenerated, 3 stale test fixtures repaired —
|
Signed-off-by: Seongho Bae <me@seonghobae.me>
…heck-source-rca fix(reviewer): bind failed checks to actionable source evidence
…rency-audit ci(actions): isolate pull request concurrency
…references docs: fix stale "active PR #80" references in automation-threat-model.md
feat(workflow): add atomic durable task claim and checkpoint CAS
Purpose and owner boundary
Replace the former Wrangler/Miniflare/Sharp development path with pinned
workerd@1.20260625.1+esbuild@0.28.1, keeping Cloudflare lifecycle truth and foreign routing/security authority outside Noema.Current authority — 2026-09-08 KST
Protected Noema normally integrated #542 and is GitHub-verified
main@d6394b2aa73e6fc57fccdad74ea38ad87f79e7f8. This lane is ordinary/non-force converged on that ancestry at exact05bc2d47c3899ebe17538070f9a30172f90307ac; fresh compare is ahead-only withbehind_by=0and merge-base exactly protected main. The effective candidate is 15 paths and does not replace #542 Durable Workflow/State/Checkpoint source orwrangler.toml.Hosted RED → causal repairs
e420b5d...patch-validator image failedMaterialize exact patch-validator dependencies: directworkerd/esbuildhad been added to the development toolchain but validator pruning still removed only Wrangler.fd8a38b6eec893c8d24cec901609820ae279b81aremoves directworkerd/esbuildbefore prune and assertsworkerd,esbuild,@esbuild, Miniflare and Wrangler are absent from the validator dependency payload. On later exactc20d915..., the validator materialization step passed and advanced to image build.After feat(workflow): add atomic durable task claim and checkpoint CAS #542 integration, exact
9aa2d9c...CI34154917767passed exact checkout/toolchain/live-base verification then failed only lockfile change control because.github/lockfile-change-policy.jsonstill bound historical protected39f3683.... Protectedpackage-lock.jsonhad not changed between39f3683...andd6394b2...; thereforec20d915c0b5cd428dc4af29760d9f95c62784267changed only policybaseShato exactd6394b2..., preserving all reviewed package digests, metadata digests, provenance sources, justification and schema. The next exact CI confirmedLockfile change control passed for 51 changed package node(s).Exact
c20d915...then exposed a second real CI RED in release tests:test/lockfile-reproducibility-workflow.test.tsandtest/upload-artifact-node24-integrity.test.tsshowed that the prior semantic convergence had accidentally dropped fix(toolchain): replace Wrangler/Miniflare GPL-family path #540's canonical lockfile-regeneration evidence steps together with its obsolete concurrency form.05bc2d47c3899ebe17538070f9a30172f90307acrestores only the intended disposablenpm install --package-lock-onlyregeneration, checksum-equivalent comparison, pinnedactions/upload-artifactevidence, and reproducibility enforcement while retaining protected PR-scoped/work-conserving concurrency and current live-base guards.Exact-head verification
On unchanged
05bc2d47..., CI34155490139is terminal success: exact checkout, live-base verification, lockfile control, canonical regeneration, artifact upload, install, typecheck, full release tests, security scan, KPI, dependency-license inventory, acquisition manifest/integrity and post-verification base-drift guard all passed. Reviewer CI34155490036and required Security Scan34155490066are also terminal success.patch-validator-image 34155490034is still running, so historical image evidence is not transferred and the PR remains Draft.Fresh review-thread inventory is clean. Normal merge is authorized only after
patch-validator-image 34155490034reaches terminal success on unchanged05bc2d47..., review/thread authority is re-read, compare remainsbehind_by=0, and protected ancestry is unchanged. No force push, destructive rebase, self-approval or gate weakening.