docs: fix stale "active PR #80" references in automation-threat-model.md - #553
Merged
Conversation
Adds ADR-0012 recording the architecture decision for unifying Noema into one shared runtime: three candidates were evaluated (shared-package, shared-service, contract-only), and shared-package won on evidence — the only real, current, same-language duplicate is the pydantic-ai Agent-construction wiring independently built in this repository's reviewer/agent.py and naruon's noema_agent.py, not the broader claims the shared-service/contract-only candidates rested on. Implements the ADR's first concrete PR: extracts the AsyncOpenAI -> OpenAIChatModel -> OpenAIProvider -> Agent(...) wiring from reviewer/noema_reviewer into a new packages/noema-core subpackage, plus a shared NOEMA_PERSONA identity fragment. reviewer/ is the sole consumer (self-consumption only); no behavior change — the existing 478-test, 100% coverage/docstring reviewer suite passes unmodified, and noema-core carries its own equivalent 100%/100% suite. Not yet published to an index; both CI (central-review.yml) and local pytest reach it via PYTHONPATH, the same mechanism already used for noema_reviewer itself. naruon's adoption, the identity/verdict-schema contract grafted from the contract-only candidate, and publishing noema-core to an index are scoped as explicit next steps in the ADR, not bundled into this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
added
priority: medium
ChatGPT Codex Connector
test(ci): forbid docs-only required-gate suppression
19 tasks
…ed-agent-wiring feat(reviewer): extract shared noema-core package (ADR-0014)
…heck-source-rca fix(reviewer): bind failed checks to actionable source evidence
…rency-audit ci(actions): isolate pull request concurrency
seonghobae
marked this pull request as ready for review
September 7, 2026 17:32
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Keep the automation threat model aligned with protected publisher race controls. Closed PR #80 is historical lineage only; this lane changes documentation/contract evidence, not runtime authority.
Current exact authority — 2026-09-07 KST
Protected Noema advanced normally through #550 to GitHub-verified
main@6b5b2c8e6a50ce383cf781c5386dff5381582f65.The predecessor #553 exact
c03d946f52faf65b1f9b75c3c601fed106ffcbd0had CI/reviewer/required Security terminal success while patch-validator-image was still in progress, but #550 then changed protected ancestry. That generation is historical only and cannot authorize merge after the base moved.This lane is now ordinary/non-force converged again. New exact
3bd9f543e97ce856f78b1c608141436298ce9e74is a two-parent commit with first parent current protectedmain@6b5b2c8...and second parent predecessor #553c03d946.... Its tree starts from current protected main and overlays only this lane's two valid paths:docs/automation-threat-model.mdandtest/documentation-architecture-contract.test.ts. Fresh compare is ahead-only withbehind_by=0, merge-base exactly current protected main, and effective diff exactly those two paths. #550's workflow-concurrency controls are therefore preserved rather than overwritten.No provider/model routing, workflow permission, quarantine/security or outbound authority moved into this lane.
Fresh exact-head verification
Fresh pull-request workflows for exact
3bd9f543...have now materialized:ci 34134906256: queued;reviewer-ci 34134906295: queued;Security Scan 34134906265: queued;patch-validator-image 34134906305: queued.Queued is non-passing. Fresh review-thread authority remains clean. Keep Draft until this unchanged exact head receives terminal-success four-gate evidence and fresh protected/central identities remain compatible. No predecessor GREEN transfers.
Summary by CodeRabbit
새 기능
개선 사항
문서