Skip to content

feat(reviewer): extract shared noema-core package (ADR-0014) - #536

Merged
seonghobae merged 138 commits into
mainfrom
feat/noema-core-shared-agent-wiring
Sep 7, 2026
Merged

feat(reviewer): extract shared noema-core package (ADR-0014)#536
seonghobae merged 138 commits into
mainfrom
feat/noema-core-shared-agent-wiring

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Scope

Introduce the minimal provider-neutral noema-core Shared Kernel. It accepts an already-resolved PydanticAI Model; contextual-orchestrator remains the provider/model discovery, credential, routing, retry and failover owner. ADR-0014 remains Proposed and external adoption requires an immutable Noema release, not this mutable PR head.

Current exact authority — 2026-09-07 KST

Protected Noema is GitHub-verified main@5cd6341866a53351ff412415f677ec2fef23ea33; protected central .github/main remains GitHub-verified c9052e607e5f3cc76e73207e7786b21500721b79.

#536 is ordinary/non-force converged onto that protected Noema head. Two-parent restack 4fe6fe84611dfa1d69d8e0712b72b278429524d0 uses current protected main as first parent and the predecessor #536 delta as second parent. Its tree preserves #543's protected exact-head regression and overlays only #536-owned reviewer/shared-core paths. No provider/model discovery, direct provider SDK ownership, retry/failover or mutable sibling dependency is introduced.

Review and verification

Fresh review-thread sweep on the current PR has zero unresolved findings; all historical Devin/CodeRabbit/GitHub Code Quality findings are resolved.

Exact-head workflow state for 4fe6fe84611dfa1d69d8e0712b72b278429524d0:

  • ci 34081562178: terminal success.
  • reviewer-ci 34081562227: terminal success.
  • required Security Scan 34081562190: terminal success.
  • patch-validator-image 34081562239: terminal success.

Immediately before promotion, protected Noema remained main@5cd6341866a53351ff412415f677ec2fef23ea33, protected central remained c9052e607e5f3cc76e73207e7786b21500721b79, and compare reported ahead_by=76, behind_by=0, merge-base exactly the protected Noema head. The PR is therefore Ready for normal merge on the unchanged exact head. No predecessor evidence transfers.

After normal integration, #535 and #548 must be ordinary/non-force converged on the protected Shared Kernel before their own exact-head evidence is accepted.

Summary by CodeRabbit

  • 새 기능

    • provider 중립적인 공유 에이전트 패키지를 추가했습니다.
    • 리뷰어가 이미 구성된 모델과 역할별 프롬프트·출력 형식을 사용하도록 개선했습니다.
    • reviewer 패키지에 공유 기능을 포함해 일반 설치와 editable 설치를 지원합니다.
  • 개선 사항

    • 모델 재시도와 장애 조치 책임을 상위 오케스트레이터로 일원화했습니다.
    • 수익·이전 증빙이 파일 경로와 SHA-256 해시로 검증되도록 강화했습니다.
    • 안전한 파일 교체와 비정상 파일 입력 처리의 신뢰성을 높였습니다.
  • 문서 및 검증

    • 관련 사용법, 아키텍처 결정, 추적성 문서를 갱신했습니다.
    • 패키징·설치·보안 경계에 대한 자동 검증을 확대했습니다.

@seonghobae
seonghobae marked this pull request as ready for review September 7, 2026 07:13
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae
seonghobae merged commit 4c1d174 into main Sep 7, 2026
18 of 19 checks passed
@seonghobae
seonghobae deleted the feat/noema-core-shared-agent-wiring branch September 7, 2026 07:14
seonghobae added a commit that referenced this pull request Sep 7, 2026
Preserve current protected main and the #548 failed-check/source-binding delta by ordinary non-force merge after #536 integration.
seonghobae added a commit that referenced this pull request Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request priority: medium Normal-priority or P2 work status: draft Draft pull request type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants