feat(reviewer): extract shared noema-core package (ADR-0014) - #536
Merged
Conversation
…ce-document-authority fix(acquisition): bind commercial source records
This was referenced Sep 7, 2026
This was referenced Sep 7, 2026
test(ci): forbid docs-only required-gate suppression
seonghobae
marked this pull request as ready for review
September 7, 2026 07:13
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
This was referenced Sep 7, 2026
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
7 tasks
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Introduce the minimal provider-neutral
noema-coreShared Kernel. It accepts an already-resolved PydanticAIModel;contextual-orchestratorremains the provider/model discovery, credential, routing, retry and failover owner. ADR-0014 remains Proposed and external adoption requires an immutable Noema release, not this mutable PR head.Current exact authority — 2026-09-07 KST
Protected Noema is GitHub-verified
main@5cd6341866a53351ff412415f677ec2fef23ea33; protected central.github/mainremains GitHub-verifiedc9052e607e5f3cc76e73207e7786b21500721b79.#536 is ordinary/non-force converged onto that protected Noema head. Two-parent restack
4fe6fe84611dfa1d69d8e0712b72b278429524d0uses current protected main as first parent and the predecessor #536 delta as second parent. Its tree preserves #543's protected exact-head regression and overlays only #536-owned reviewer/shared-core paths. No provider/model discovery, direct provider SDK ownership, retry/failover or mutable sibling dependency is introduced.Review and verification
Fresh review-thread sweep on the current PR has zero unresolved findings; all historical Devin/CodeRabbit/GitHub Code Quality findings are resolved.
Exact-head workflow state for
4fe6fe84611dfa1d69d8e0712b72b278429524d0:ci 34081562178: terminal success.reviewer-ci 34081562227: terminal success.Security Scan 34081562190: terminal success.patch-validator-image 34081562239: terminal success.Immediately before promotion, protected Noema remained
main@5cd6341866a53351ff412415f677ec2fef23ea33, protected central remainedc9052e607e5f3cc76e73207e7786b21500721b79, and compare reportedahead_by=76,behind_by=0, merge-base exactly the protected Noema head. The PR is therefore Ready for normal merge on the unchanged exact head. No predecessor evidence transfers.After normal integration, #535 and #548 must be ordinary/non-force converged on the protected Shared Kernel before their own exact-head evidence is accepted.
Summary by CodeRabbit
새 기능
개선 사항
문서 및 검증