Skip to content

fix(oidc): roll forward current central workflow source - #450

Merged
seonghobae merged 2 commits into
mainfrom
fix/oidc-current-central-daf5ad
Aug 22, 2026
Merged

fix(oidc): roll forward current central workflow source#450
seonghobae merged 2 commits into
mainfrom
fix/oidc-current-central-daf5ad

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Central read-only .github protected main advanced to daf5ad43b48c826a3a119f385a2f80bef893ae49 while protected Noema main still trusts 322004186dd34736bc073e69406c41d2f435f8e4 in ALLOWED_WORKFLOW_SHA.

The audited noema-review.yml blob remains unchanged (59b25e343444d0b97fc1c7ba33cb15543dd70102), but GitHub OIDC job_workflow_sha binds the immutable source commit. This Draft begins with a TDD RED: test/trusted-workflow-source-rollforward.test.ts now requires the current central source commit while production configuration is intentionally still stale.

Next step on this same canonical lane is to change only Noema wrangler.toml to the audited central commit, then require fresh exact-head application CI, reviewer-ci, and eligible central Security Scan before Ready/merge.

Central .github remains read-only.

Merge boundary

Draft. Do not merge until RED→GREEN is complete, live central source is refetched unchanged, all applicable exact-head gates are terminal-success, and review/thread state plus protected base are freshly clean.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f271712-32c6-46ee-ad2f-b388df6a3d19

📥 Commits

Reviewing files that changed from the base of the PR and between c662013 and 2c047f0.

📒 Files selected for processing (2)
  • test/trusted-workflow-source-rollforward.test.ts
  • wrangler.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 22, 2026 13:14
@seonghobae
seonghobae merged commit ab3ebde into main Aug 22, 2026
16 of 17 checks passed
@seonghobae
seonghobae deleted the fix/oidc-current-central-daf5ad branch August 22, 2026 13:14

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread wrangler.toml
ALLOWED_WORKFLOW_REPOSITORY = "ContextualWisdomLab/.github"
ALLOWED_WORKFLOW_REF_PREFIX = "ContextualWisdomLab/.github/.github/workflows/noema-review.yml@refs/heads/main"
ALLOWED_WORKFLOW_SHA = "322004186dd34736bc073e69406c41d2f435f8e4"
ALLOWED_WORKFLOW_SHA = "daf5ad43b48c826a3a119f385a2f80bef893ae49"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Diff rolls config forward despite RED intent

The description says this draft keeps wrangler.toml stale at the old SHA as a TDD RED step, but wrangler.toml is already updated to daf5ad43... matching the test, so the gate is GREEN. Either the config change is premature or the description is stale. The new SHA itself cannot be verified against the central repo here.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

seonghobae pushed a commit that referenced this pull request Aug 30, 2026
Reapply PR #425's content onto current main after an unrelated git
history rewrite orphaned the branch's original base commit
(a779375, pre-#450) from main's history (root ab3ebde, from #450
onward). README.md was byte-identical between the old base and
current main, so the PR's own README.md diff applies verbatim.

- Rewrite README.md as a customer/operator surface: product purpose,
  standalone run/deploy, /health /ready /exchange, orchestrator
  gateway contract, naruon/gyeot hub table, GitHub App permissions,
  operator vars, and links to onboarding/runbook/API
  spec/threat-model/deployment guide/SLA/OpenAPI.
- Add docs/internal/README.md so maintainers still find the
  hourly-loop, acquisition, saleable-program, and KPI collect
  internals that moved out of the customer README.
- Update the CHANGELOG.md Unreleased entry to the PR's refined
  wording, replacing the earlier draft of the same bullet already
  present on main.

test/readme-customer-facing.test.ts continues to pass.
seonghobae pushed a commit that referenced this pull request Aug 30, 2026
…e) into current main

origin/main's history was rewritten (new root ab3ebde at PR #450);
this PR's original base commit a779375 (#423-era) and its one
commit 7d95ca2 predate that rewrite and share no ancestor with
current main, so a normal merge is refused
("refusing to merge unrelated histories").

This records the old branch tip as merged history (satisfying
"merge base into head", not a rebase, and not a force-push) while
keeping the tree from the preceding commit, which already carries
the old branch's content reapplied onto current main by hand
(README.md patch applied verbatim since it was byte-identical at
the old base; docs/internal/README.md copied from the old head;
CHANGELOG.md bullet updated to the old head's wording).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant