Skip to content

fix(oidc): roll forward current central workflow source #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 2 commits into from
Aug 22, 2026
Merged

fix(oidc): roll forward current central workflow source #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d85bd1
test(oidc): require current central workflow source
seonghobae Aug 22, 2026
2c047f0
fix(oidc): trust current central workflow source
seonghobae Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/trusted-workflow-source-rollforward.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";

const auditedCentralWorkflowSourceSha =
"322004186dd34736bc073e69406c41d2f435f8e4";
"daf5ad43b48c826a3a119f385a2f80bef893ae49";

describe("trusted central workflow source revision", () => {
it("binds the deployed OIDC trust configuration to the audited central source commit", () => {
Expand Down
2 changes: 1 addition & 1 deletion wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ALLOWED_AUDIENCE = "cwl-noema-review"
ALLOWED_REPOSITORY_OWNER = "ContextualWisdomLab"
ALLOWED_WORKFLOW_REPOSITORY = "ContextualWisdomLab/.github"
ALLOWED_WORKFLOW_REF_PREFIX = "ContextualWisdomLab/.github/.github/workflows/noema-review.yml@refs/heads/main"
ALLOWED_WORKFLOW_SHA = "322004186dd34736bc073e69406c41d2f435f8e4"
ALLOWED_WORKFLOW_SHA = "daf5ad43b48c826a3a119f385a2f80bef893ae49"

@devin-ai-integration devin-ai-integration Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Diff rolls config forward despite RED intent

The description says this draft keeps wrangler.toml stale at the old SHA as a TDD RED step, but wrangler.toml is already updated to daf5ad43... matching the test, so the gate is GREEN. Either the config change is premature or the description is stale. The new SHA itself cannot be verified against the central repo here.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

GITHUB_API_BASE = "https://api.github.com"
GITHUB_APP_SLUG = "noema"
NOEMA_RATE_LIMIT_PER_MINUTE = "60"
Expand Down
Loading