refactor: update UI/UX terminology to match Naruon philosophy - #340
Conversation
- Map 'AI Summary' to '맥락 종합' - Map 'Insight' to '판단 포인트' - Map 'Todo' to '실행 항목' - Map 'Calendar Sync' to '일정 반영' - Map 'Dashboard' to '홈' - Map 'Email' to '메일' - Update related test cases and e2e specs to reflect new text - Fix grammatical postpositions for Korean strings
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 56 minutes and 42 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates Korean UI terminology across the frontend: 이메일→메일, 캘린더 반영→일정 반영, 할 일→실행 항목, and 요약→맥락 종합 in components, unit/page tests, and e2e specs. ChangesKorean UI Terminology and Branding Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
|
PR governance metadata gate is not ready for
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/DashboardLayout.tsx`:
- Line 76: The message string for the menu item object (label: '실행 항목 생성',
action: 'create-task', icon: CheckCircle2) in DashboardLayout.tsx contains a
duplicated phrase ("실행 항목을 실행 항목으로"); update the message to a clear,
non-redundant Korean phrase (for example, "메일 상세 패널에서 실행 항목으로 정리합니다." or "메일 상세
패널에서 실행 항목을 생성합니다.") by editing the message value in that object so the
user-facing text reads naturally and without repetition.
In `@frontend/src/components/TasksLayout.tsx`:
- Line 523: The div in TasksLayout.tsx with class "flex items-center gap-1
hover:text-primary transition-colors cursor-pointer" is visually clickable but
inert; replace it with a real interactive element (preferably an anchor <a> if
it navigates to the mail source or a <button> if it triggers an action) and wire
it to the appropriate handler/href (use the mail source URL prop used in this
component), add keyboard accessibility (focus styles, onKeyDown if needed) and
an accessible name/aria-label (preserve the title "메일 출처 바로가기"), or if no
interaction is intended remove the cursor-pointer and hover styles to avoid
misleading affordance. Ensure the element in TasksLayout.tsx exposes proper
semantics rather than leaving the plain div.
In `@frontend/tests/e2e/dashboard-branding.spec.ts`:
- Line 1537: The test fixes a typo in the expected string: update the call to
detailRegion.getByText that currently looks for '2개 실행 항목을 티켓형 실행 항목로 추적합니다.' to
instead expect the grammatically correct '2개 실행 항목을 티켓형 실행 항목으로 추적합니다.' so the
assertion uses the corrected copy; locate the assertion using
detailRegion.getByText and replace the incorrect substring accordingly.
In `@frontend/tests/e2e/dashboard-flows.spec.ts`:
- Line 55: Typo in the assertion string inside
frontend/tests/e2e/dashboard-flows.spec.ts: update the text passed to
detailRegion.getByText from '2개 실행 항목을 티켓형 실행 항목로 추적합니다.' to the correct '2개 실행
항목을 티켓형 실행 항목으로 추적합니다.' so the expectation matches the UI copy; locate the call
to detailRegion.getByText and replace the mistaken '로' with '으로'.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f8e63cc1-d63c-4400-918f-79338a0d5f34
📒 Files selected for processing (22)
frontend/src/app/ai-hub/page.test.tsxfrontend/src/app/layout.test.tsxfrontend/src/app/layout.tsxfrontend/src/app/page.test.tsxfrontend/src/app/prompt-studio/page.tsxfrontend/src/app/tasks/page.test.tsxfrontend/src/components/DashboardLayout.test.tsxfrontend/src/components/DashboardLayout.tsxfrontend/src/components/EmailDetail.test.tsxfrontend/src/components/EmailDetail.tsxfrontend/src/components/EmailList.tsxfrontend/src/components/NetworkGraph.tsxfrontend/src/components/ProjectsLayout.tsxfrontend/src/components/SettingsLayout.test.tsxfrontend/src/components/SettingsLayout.tsxfrontend/src/components/TasksLayout.tsxfrontend/src/components/WorkspaceHome.tsxfrontend/src/components/mobile-workspace-panels.tsxfrontend/src/components/ui/control-sizing.test.tsxfrontend/tests/e2e/dashboard-branding.spec.tsfrontend/tests/e2e/dashboard-flows.spec.tsfrontend/tests/e2e/scrolling.spec.ts
- Map 'AI Summary' to '맥락 종합' - Map 'Insight' to '판단 포인트' - Map 'Todo' to '실행 항목' - Map 'Calendar Sync' to '일정 반영' - Map 'Dashboard' to '홈' - Map 'Email' to '메일' - Update related test cases and e2e specs to reflect new text - Fix grammatical postpositions for Korean strings
- Map 'AI Summary' to '맥락 종합' - Map 'Insight' to '판단 포인트' - Map 'Todo' to '실행 항목' - Map 'Calendar Sync' to '일정 반영' - Map 'Dashboard' to '홈' - Map 'Email' to '메일' - Update related test cases and e2e specs to reflect new text - Fix grammatical postpositions for Korean strings
- Increase overall job timeout-minutes from 90 to 120 - Increase `process_budget_seconds` from 2400 to 3600 - Increase `LLM_TIMEOUT` from 90 to 120 - Increase `STRIX_TOTAL_TIMEOUT_SECONDS` from 4800 to 7200 This addresses the `Strix run timed out after 2400s (exit code 124)` failure observed in CI.
1 participant
Replaces outdated terminology like 'AI Summary', 'Insight', 'Dashboard', 'Todo', etc., with '맥락 종합', '판단 포인트', '홈', '실행 항목', and other Naruon-approved terms across the frontend codebase as defined in the provided guidelines. All corresponding unit tests and playwright specs have been updated to ensure the build passes.
PR created automatically by Jules for task 4048639708573802158 started by @seonghobae
Summary by CodeRabbit
Chores
Tests