π¨ Palette: [UX improvement] Update terminology from "μμ½" to "μ’ ν©" - #1154
seonghobae wants to merge 2 commits into
Conversation
π‘ What
- `SourceDrawer.tsx` μ»΄ν¬λνΈ λ΄μ ν
μ€νΈ "μ¦κ±° μμ½"μ "μ¦κ±° μ’
ν©"μΌλ‘ λ³κ²½νμ΅λλ€.
- κ΄λ ¨λ ν
μ€νΈ νμΌ (`search/page.test.tsx`)μ λͺ©μ
λ°μ΄ν°μμλ "Q2 μΌμ μμ½"μ "Q2 μΌμ μ’
ν©"μΌλ‘ λ³κ²½νμ΅λλ€.
π― Why
- Naruonμ ν΅μ¬ UX μ² ν λ° κΈ°ν λ¬Έμ(`naruon-ui-ux-mapping.md`)μ μ μλ μ©μ΄ κ·μΉ("Summary -> μ’
ν©, ν΅μ¬ λ§₯λ½")μ μ€μνκΈ° μν¨μ
λλ€. "μμ½" λμ "μ’
ν©"μ΄λΌλ ννμ μ¬μ©νμ¬ λ§₯λ½μ λ¨μν μ€μ΄λ κ²μ΄ μλλΌ λͺ¨μμ νλ¨μ λλλ€λ μλ―Έλ₯Ό λͺ
νν ν©λλ€.
πΈ Before/After
- λ³κ²½ μ : "μ¦κ±° μμ½"
- λ³κ²½ ν: "μ¦κ±° μ’
ν©"
βΏ Accessibility
- μ€ν¬λ¦° 리λ λ± λ³΄μ‘° κΈ°μ μ¬μ© μμλ Naruonμ μΌκ΄λ κΈ°ν μλμ λ§λ μ©μ΄("μ’
ν©")κ° μ λ¬λλλ‘ κ°μ λμμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (2)
π WalkthroughWalkthroughThe search answer test fixtures now use βQ2 μΌμ μ’ ν©β, and the source drawer summary heading changed from βμ¦κ±° μμ½β to βμ¦κ±° μ’ ν©β. ChangesSearch terminology alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 4β Passed checks (4 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
|
PR governance metadata gate is not ready for
|
There was a problem hiding this comment.
Pull request overview
Updates Korean UX terminology to align with the productβs terminology rules by replacing βμμ½β with βμ’ ν©β in a user-facing label and keeping related test mock data consistent.
Changes:
- Update
SourceDrawersection header text from βμ¦κ±° μμ½β to βμ¦κ±° μ’ ν©β. - Update Search page test mock snippets from βQ2 μΌμ μμ½β to βQ2 μΌμ μ’ ν©β.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/SourceDrawer.tsx | Updates a hardcoded UI label to the preferred terminology (βμ¦κ±° μ’ ν©β). |
| frontend/src/app/search/page.test.tsx | Aligns test mock data strings with the updated terminology to prevent assertion/mismatch issues. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head0dbc09fcba37c84c50c154fa415b9d58a697c6e5. -
Head SHA:
0dbc09fcba37c84c50c154fa415b9d58a697c6e5 -
Workflow run: 30532461676
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Frontend (2 files)"]
S1 --> I1["browser runtime and bundle"]
I1 --> R1["Review risk: Frontend (2 files)"]
R1 --> V1["frontend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Frontend (2 files)"]
S1 --> I1["browser runtime and bundle"]
I1 --> R1["Review risk: Frontend (2 files)"]
R1 --> V1["frontend tests"]
|
|
Superseded duplicate Palette UX/terminology/loading cohort. Close to drain PR queue; re-land single focused PR if still needed on develop. |
Understood. Acknowledging that this work is superseded and closing as requested. I will stop work on this task. |
π‘ What
frontend/src/components/SourceDrawer.tsxνμΌ λ΄μμ νλμ½λ©λ "μ¦κ±° μμ½" ν μ€νΈλ₯Ό "μ¦κ±° μ’ ν©"μΌλ‘ λ³κ²½νμ΅λλ€.frontend/src/app/search/page.test.tsxνμΌ λ΄μ ν μ€νΈ λͺ©μ λ°μ΄ν°μμ "Q2 μΌμ μμ½"μ "Q2 μΌμ μ’ ν©"μΌλ‘ μΌμΉλκ² μ λ°μ΄νΈνμ΅λλ€.cd frontend && pnpm run test) νκ·(regression)κ° μμμ νμΈνμ΅λλ€.update.patchνμΌμ λ¦¬λ·°μ΄ νΌλλ°±μ λ°λΌ μμ νμ΅λλ€.π― Why
docs/ui-ux/naruon-ui-ux-mapping.md)μμλ "Summary"λ₯Ό "μμ½" λμ "μ’ ν©" λλ "ν΅μ¬ λ§₯λ½"μΌλ‘ μ¬μ©νλλ‘ μ격νκ² κ·μΉ(Terminology Rules)μ μ νκ³ μμ΅λλ€.πΈ Before/After
βΏ Accessibility
PR created automatically by Jules for task 8243381197382916517 started by @seonghobae
Summary by CodeRabbit