Skip to content

🎨 Palette: [UX improvement] Update terminology from "μš”μ•½" to "μ’…ν•©" - #1154

Closed
seonghobae wants to merge 2 commits into
developfrom
fix-ui-terminology-summary-8243381197382916517
Closed

seonghobae wants to merge 2 commits into
developfrom
fix-ui-terminology-summary-8243381197382916517

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

πŸ’‘ What

  • frontend/src/components/SourceDrawer.tsx 파일 λ‚΄μ—μ„œ ν•˜λ“œμ½”λ”©λœ "증거 μš”μ•½" ν…μŠ€νŠΈλ₯Ό "증거 μ’…ν•©"으둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
  • frontend/src/app/search/page.test.tsx 파일 λ‚΄μ˜ ν…ŒμŠ€νŠΈ λͺ©μ—… λ°μ΄ν„°μ—μ„œ "Q2 일정 μš”μ•½"을 "Q2 일정 μ’…ν•©"으둜 일치되게 μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
  • κ΄€λ ¨λœ ν”„λ‘ νŠΈμ—”λ“œ ν…ŒμŠ€νŠΈλ₯Ό μ‹€ν–‰ν•˜μ—¬(cd frontend && pnpm run test) νšŒκ·€(regression)κ°€ μ—†μŒμ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.
  • 패치 μ μš©μ„ μœ„ν•΄ μž„μ‹œλ‘œ μƒμ„±ν–ˆλ˜ update.patch νŒŒμΌμ€ 리뷰어 ν”Όλ“œλ°±μ— 따라 μ‚­μ œν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

  • Naruon μ œν’ˆμ˜ UX/UI 기획 κ°€μ΄λ“œλΌμΈ(docs/ui-ux/naruon-ui-ux-mapping.md)μ—μ„œλŠ” "Summary"λ₯Ό "μš”μ•½" λŒ€μ‹  "μ’…ν•©" λ˜λŠ” "핡심 λ§₯락"으둜 μ‚¬μš©ν•˜λ„λ‘ μ—„κ²©ν•˜κ²Œ κ·œμΉ™(Terminology Rules)을 μ •ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€.
  • μ΄λŠ” Naruon이 λ‹¨μˆœνžˆ λ‚΄μš©μ„ μ€„μ΄λŠ” μš”μ•½ 도ꡬ가 μ•„λ‹ˆλΌ, μ—¬λŸ¬ μ •λ³΄μ˜ λ§₯락을 μ—°κ²°ν•˜μ—¬ νŒλ‹¨κ³Ό 싀행을 λ•λŠ” λ„κ΅¬λΌλŠ” 핡심 철학을 λ°˜μ˜ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.

πŸ“Έ Before/After

  • Before: SourceDrawerμ—μ„œ "증거 μš”μ•½"으둜 ν‘œμ‹œλ¨, ν…ŒμŠ€νŠΈ κ²°κ³Όμ—μ„œ "Q2 일정 μš”μ•½" λ¬Έμžμ—΄ μ‚¬μš©.
  • After: SourceDrawerμ—μ„œ "증거 μ’…ν•©"으둜 ν‘œμ‹œλ¨, ν…ŒμŠ€νŠΈ κ²°κ³Όμ—μ„œ "Q2 일정 μ’…ν•©" λ¬Έμžμ—΄ μ‚¬μš©.

β™Ώ Accessibility

  • N/A (μ‹œκ°μ /ꡬ쑰적 μ ‘κ·Όμ„± κ΄€λ ¨ λ³€κ²½ 사항은 μ—†μœΌλ©°, 순수 ν…μŠ€νŠΈ(μš©μ–΄) 변경에 ν•΄λ‹Ήν•©λ‹ˆλ‹€.)

PR created automatically by Jules for task 8243381197382916517 started by @seonghobae

Summary by CodeRabbit

  • Style
    • Updated the source drawer heading to use revised Korean terminology.
  • Tests
    • Updated search answer test data to match the revised Q2 snippet wording.

πŸ’‘ What
- `SourceDrawer.tsx` μ»΄ν¬λ„ŒνŠΈ λ‚΄μ˜ ν…μŠ€νŠΈ "증거 μš”μ•½"을 "증거 μ’…ν•©"으둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
- κ΄€λ ¨λœ ν…ŒμŠ€νŠΈ 파일 (`search/page.test.tsx`)의 λͺ©μ—… λ°μ΄ν„°μ—μ„œλ„ "Q2 일정 μš”μ•½"을 "Q2 일정 μ’…ν•©"으둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why
- Naruon의 핡심 UX μ² ν•™ 및 기획 λ¬Έμ„œ(`naruon-ui-ux-mapping.md`)에 μ •μ˜λœ μš©μ–΄ κ·œμΉ™("Summary -> μ’…ν•©, 핡심 λ§₯락")을 μ€€μˆ˜ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€. "μš”μ•½" λŒ€μ‹  "μ’…ν•©"μ΄λΌλŠ” ν‘œν˜„μ„ μ‚¬μš©ν•˜μ—¬ λ§₯락을 λ‹¨μˆœνžˆ μ€„μ΄λŠ” 것이 μ•„λ‹ˆλΌ λͺ¨μ•„μ„œ νŒλ‹¨μ„ λ•λŠ”λ‹€λŠ” 의미λ₯Ό λͺ…ν™•νžˆ ν•©λ‹ˆλ‹€.

πŸ“Έ Before/After
- λ³€κ²½ μ „: "증거 μš”μ•½"
- λ³€κ²½ ν›„: "증거 μ’…ν•©"

β™Ώ Accessibility
- 슀크린 리더 λ“± 보쑰 기술 μ‚¬μš© μ‹œμ—λ„ Naruon의 μΌκ΄€λœ 기획 μ˜λ„μ— λ§žλŠ” μš©μ–΄("μ’…ν•©")κ°€ μ „λ‹¬λ˜λ„λ‘ κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
Copilot AI review requested due to automatic review settings July 26, 2026 14:11
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 99d038e3-7f8f-4523-8da7-4654fe53f541

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between eae74e2 and 0dbc09f.

πŸ“’ Files selected for processing (2)
  • frontend/src/app/search/page.test.tsx
  • frontend/src/components/SourceDrawer.tsx

πŸ“ Walkthrough

Walkthrough

The search answer test fixtures now use β€œQ2 일정 쒅합”, and the source drawer summary heading changed from β€œμ¦κ±° μš”μ•½β€ to β€œμ¦κ±° 쒅합”.

Changes

Search terminology alignment

Layer / File(s) Summary
Terminology and test fixture updates
frontend/src/components/SourceDrawer.tsx, frontend/src/app/search/page.test.tsx
The source drawer heading and grounded search answer citation snippets now use β€œμ’…ν•©β€ terminology.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: copilot

πŸš₯ Pre-merge checks | βœ… 4
βœ… Passed checks (4 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title clearly matches the main change: updating Korean terminology from β€œμš”μ•½β€ to β€œμ’…ν•©β€ in the frontend.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ui-terminology-summary-8243381197382916517

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 0dbc09fcba37c84c50c154fa415b9d58a697c6e5:

  • Review decision is CHANGES_REQUESTED; address requested changes before merge.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Korean UX terminology to align with the product’s terminology rules by replacing β€œμš”μ•½β€ with β€œμ’…ν•©β€ in a user-facing label and keeping related test mock data consistent.

Changes:

  • Update SourceDrawer section header text from β€œμ¦κ±° μš”μ•½β€ to β€œμ¦κ±° 쒅합”.
  • Update Search page test mock snippets from β€œQ2 일정 μš”μ•½β€ to β€œQ2 일정 쒅합”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/src/components/SourceDrawer.tsx Updates a hardcoded UI label to the preferred terminology (β€œμ¦κ±° 쒅합”).
frontend/src/app/search/page.test.tsx Aligns test mock data strings with the updated terminology to prevent assertion/mismatch issues.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 0dbc09fcba37c84c50c154fa415b9d58a697c6e5.

  • Head SHA: 0dbc09fcba37c84c50c154fa415b9d58a697c6e5

  • Workflow run: 30532461676

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Frontend (2 files)"]
  S1 --> I1["browser runtime and bundle"]
  I1 --> R1["Review risk: Frontend (2 files)"]
  R1 --> V1["frontend tests"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 0dbc09fcba37c84c50c154fa415b9d58a697c6e5
  • Workflow run: 30532461676
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 0dbc09fcba37c84c50c154fa415b9d58a697c6e5.

  • Head SHA: 0dbc09fcba37c84c50c154fa415b9d58a697c6e5

  • Workflow run: 30532461676

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Frontend (2 files)"]
  S1 --> I1["browser runtime and bundle"]
  I1 --> R1["Review risk: Frontend (2 files)"]
  R1 --> V1["frontend tests"]
Loading

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded duplicate Palette UX/terminology/loading cohort. Close to drain PR queue; re-land single focused PR if still needed on develop.

@seonghobae seonghobae closed this Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded duplicate Palette UX/terminology/loading cohort. Close to drain PR queue; re-land single focused PR if still needed on develop.

Understood. Acknowledging that this work is superseded and closing as requested. I will stop work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants