refactor(ata): own fixed-form greedy assembly in Rust - #753
Conversation
Public assemble_test_form validates and marshals only; ordering, exclusion, and content-feasibility decisions move to assemble_test_form_greedy with ownership sentinel tests, changelog fragment, and APA doctoring. Supersedes draft #747 once green.
|
Warning Review limit reached
Next review available in: 15 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fail closed on non-negative content counts without reflecting caller-controlled label strings in ValueError messages.
Why
Draft #747 is a RED ownership contract (test-only). Production fixed-form assembly still runs the greedy heuristic in Python.
What
mlsirm_core::test_form::assemble_test_form_greedyowns ordering, exclusion, and content min/max feasibility look-aheadassemble_test_form_greedybinding on_coreassemble_test_formvalidates/marshals only and transports Rust resultsVerification
cargo test -p mlsirm-core --lib test_form(5 pass)pytest tests/test_test_form_rust_ownership.py tests/test_cov_a_test_design.py(16 pass)pytest tests/test_irt_stability.py -k assemble(1 pass)Supersedes #747 once product gates are green.
changelog
See
docs/changelog.d/747-test-form-rust-ownership.mdand Unreleased Fixed.