Skip to content

refactor(ata): rebase fixed-form Rust ownership RED on current main - #750

Closed
seonghobae wants to merge 1 commit into
mainfrom
refactor/test-form-assembly-rust-main-20260811-v2
Closed

refactor(ata): rebase fixed-form Rust ownership RED on current main#750
seonghobae wants to merge 1 commit into
mainfrom
refactor/test-form-assembly-rust-main-20260811-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

Protected main advanced three commits after Draft #747 was created. #747's only unique delta is the intentional public-boundary RED for fixed-form greedy assembly ownership, so this clean-lineage replacement recreates that exact contract on current protected main without transferring predecessor checks/reviews.

Intentional RED

tests/test_test_form_rust_ownership.py replaces proposed _core.assemble_test_form_greedy with a sentinel valid form and requires public assemble_test_form() to return it while preserving caller information/content/exclusion arrays. Current Python-owned ordering/content-feasibility logic should fail the delegation assertion after normal Rust/PyO3 package setup.

Exact identity

  • protected base at creation: cd9e55f7f1735e9d73e73c11f5790d3c8e2f2b55;
  • clean replacement head: ba9685b965c64a170ff5ca566f750d3ae4225769;
  • changed path: tests/test_test_form_rust_ownership.py only.

Minimum GREEN

Move descending finite-information ordering, exclusion filtering, deterministic ties, content minima/maxima and look-ahead feasibility into one bounded mlsirm-core kernel. Expose thin PyO3 marshalling; Python validates/types/canonical content labels and transports only. Preserve current deterministic behavior and fail closed when compiled capability is absent. Add direct parity/resource/adversarial/immutability evidence, docs/rustdoc and changelog after GREEN, then one unchanged head with Python 3.12/3.14, Rust/PyO3, package/reinstall, existing GPU/fuzz, Security/SAST and current-head governance gates.

No stronger ATA optimizer, provider, hosted state, workflow/dependency/version/release or competing canonical docs belongs here. Advances #629. Supersedes #747 once this clean replacement is established.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 436515a0-aff3-43ec-b4fe-1707955785f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by GREEN ownership PR (#753 form assembly / #755 linking). Closing RED test-only refresh.

@seonghobae seonghobae closed this Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by clean current-main Draft #756.

Fresh lineage evidence:

No #750 checks/reviews/approval/base-sensitive evidence transfers. #756 is now the sole current-lineage implementation/RED authority for the fixed-form assembly ownership slice. Closing this stale duplicate drops no unique value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant